Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SEK to supported currencies. #1357

Merged
merged 1 commit into from
Apr 8, 2022
Merged

Conversation

teevans
Copy link
Member

@teevans teevans commented Apr 8, 2022

What does this PR change?

Adds Swedish Krona (SEK) to the supported currencies.

Does this PR rely on any other PRs?

Yes - The Front-End PR should be merged in first.
https://github.com/kubecost/cost-analyzer-frontend/pull/590

How does this PR impact users? (This is the kind of thing that goes in release notes!)

Allows users to show their spend in Swedish Krona!

Links to Issues or ZD tickets this PR addresses or fixes

https://github.com/kubecost/cost-analyzer-frontend/pull/590
#1352

How was this PR tested?

No testing.

Have you made an update to documentation?

No.

Copy link
Contributor

@michaelmdresser michaelmdresser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Many of us share PRs that need review in the eng slack channel. Not a hard and fast rule, but it helps get faster reviews sometimes 😁

@teevans teevans merged commit 6b3e8d3 into develop Apr 8, 2022
@chipzoller chipzoller deleted the thomas/swedish-kronor branch October 4, 2023 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants