Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade turndownschedules CRD to apiextensions v1 #44

Merged
merged 1 commit into from
May 27, 2022

Commits on May 27, 2022

  1. Upgrade turndownschedules CRD to apiextensions v1

    apiextensions.k8s.io/v1beta1 is removed as of K8s v1.22 [1], so all CRDs
    have to be updated to apiextensions.k8s.io/v1. This commit does the
    upgrade for the turndownschedule CRD.
    
    As part of the API updates, K8s is enforcing things grouped under
    *.k8s.io to be approved [2] because they are actually supposed to be
    Kuberenetes community-managed APIs [3]. So this commit also changes the
    CRD from:
    
    turndownschedules.kubecost.k8s.io
    to
    turndownschedules.kubecost.com
    
    This is in-line with K8s rules and links to our main domain.
    
    Tested by applying cluster-turndown-full.yaml and example-schedule.yaml
    successfully.
    
    [1] https://cloud.google.com/kubernetes-engine/docs/deprecations/apis-1-22
    [2] kubernetes/enhancements#1111
    [3] kubernetes/enhancements#1111 (comment)
    michaelmdresser committed May 27, 2022
    Configuration menu
    Copy the full SHA
    4b898df View commit details
    Browse the repository at this point in the history