feat(config): reload global config when config file is updated #1862
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
…h other dynamic configs Signed-off-by: tesla59 <[email protected]>
tesla59
force-pushed
the
tesla/non-k8s/dynamic-config
branch
from
81aebd4 to
db299d2
Compare
|
@daemon1024 @DelusionalOptimist @Prateeknandle @rootxrishabh please review. I have added throttling configs to dynamic config as well |
Prateeknandle
requested review from
DelusionalOptimist,
daemon1024,
Prateeknandle and
rootxrishabh
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
Signed-off-by: tesla59 <[email protected]>
Prateeknandle
force-pushed
the
tesla/non-k8s/dynamic-config
branch
2 times, most recently
from
050b84f to
6306430
Compare
Prateeknandle
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Tested locally, works as expected.
Thanks @tesla59 for you contributions, great work
daemon1024
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
Fixes #1303
part of #1815
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>