Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(apparmor/host): streamline host profile generation with container template generation #1861

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

daemon1024
Copy link
Member

deprecating special handling of host profiles

Purpose of PR?:

Fixes #

Does this PR introduce a breaking change?

If the changes in this PR are manually verified, list down the scenarios covered::

Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs

Checklist:

  • Bug fix. Fixes #
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests
  • Commit has integration tests

Copy link
Member

@Aryan-sharma11 Aryan-sharma11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally working fine, just some nits to address.

KubeArmor/enforcer/appArmorEnforcer.go Outdated Show resolved Hide resolved
KubeArmor/enforcer/appArmorEnforcer.go Outdated Show resolved Hide resolved
rksharma95
rksharma95 previously approved these changes Sep 9, 2024
@Aryan-sharma11 Aryan-sharma11 self-requested a review September 9, 2024 14:27
… template generation

- deprecating special handling of host profiles
- making reload of apparmor profiles only in k8s env

Signed-off-by: daemon1024 <[email protected]>
@Aryan-sharma11 Aryan-sharma11 merged commit dacac4a into kubearmor:main Sep 9, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants