Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: updated the main diagram & updater script #1806

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

nyrahul
Copy link
Contributor

@nyrahul nyrahul commented Jul 12, 2024

Purpose of PR?:
Updates the primary arch diagram:

  • Remove SELinux and only show BPFLSM, AppArmor
  • external integrations
  • take into consideration non-k8s ecosystem (VM, pure-containerized deployments)

Updates to FAQ:

  • Updated the FAQ related to updater script. We now have an updater script that can perform RollingUpdate (thanks to @achrefbensaad).
  • Added an FAQ for k3s on WSL2

Does this PR introduce a breaking change?
No

If the changes in this PR are manually verified, list down the scenarios covered::
NA

Checklist:

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • PR Title follows the convention of <type>(<scope>): <subject>
  • Commit has unit tests (NA)
  • Commit has integration tests (NA)

Signed-off-by: Rahul Jadhav <[email protected]>
Signed-off-by: Rahul Jadhav <[email protected]>
@nyrahul nyrahul changed the title docs: updated the main diagram docs: updated the main diagram & updater script Jul 13, 2024
Signed-off-by: Rahul Jadhav <[email protected]>
Copy link
Member

@achrefbensaad achrefbensaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@DelusionalOptimist DelusionalOptimist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achrefbensaad achrefbensaad merged commit 0144213 into kubearmor:main Jul 15, 2024
7 checks passed
Comment on lines +101 to +102
grep "GRUB_CMDLINE_LINUX.*bpf" /rootfs/etc/default/grub >/dev/null
[[ $? -eq 0 ]] && echo "grub already has BPF enabled" && sleep infinity
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to update this logic. There's a lot of other bpf related options that can be specified in boot parameters related to bpf. Azure Mariner Linux does mention it and the script assumes that bpflsm is enabled when it's not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants