fix(operator): fix tls rotation logic for controller #1757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rksharma95
requested review from
achrefbensaad,
daemon1024 and
DelusionalOptimist
daemon1024
approved these changes
May 23, 2024
daemon1024
force-pushed
the
fix-controller
branch
from
efb128f to
9f33ad6
Compare
Aryan-sharma11
approved these changes
May 24, 2024
DelusionalOptimist
approved these changes
May 27, 2024
|
@rksharma95 please rebase with main. We'll be good to merge then. : ) |
Signed-off-by: rksharma95 <[email protected]>
rksharma95
force-pushed
the
fix-controller
branch
from
9f33ad6 to
69ce963
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of PR?:
With the release of version 1.3.4, RBAC permissions have been optimized to allow get, update, and delete operations only on secrets managed by the operator. The existing TLS certificate rotation logic for the controller was not compatible with these restricted RBAC permissions. This PR introduces changes to ensure that the certificate rotation logic functions correctly within the assigned RBAC permissions. It also improves the logic to avoid force cert rotation on operator initialization.
Does this PR introduce a breaking change?
No
If the changes in this PR are manually verified, list down the scenarios covered::
Additional information for reviewer? :
Mention if this PR is part of any design or a continuation of previous PRs
Checklist:
<type>(<scope>): <subject>