feat(deployment): Enhance Docker ImagePull Secrets Configuration #1754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@janavenkat thanks for the PR, Lets extend the imagePullSecret configuration to operator deployment model as well. Let me know if anything is needed from my side. |
Sure will add changes for operator as well. |
janavenkat
force-pushed
the
jana/add-image-pull-secrets
branch
2 times, most recently
from
1a6e8ba
to
964e27b
Compare
Added for Operator as well |
janavenkat
force-pushed
the
jana/add-image-pull-secrets
branch
6 times, most recently
from
364c4bf
to
692973b
Compare
In larger production environments, we may get rate-limited by Docker Hub for a lot of image pulls. So, I've added an option for providing the Docker pull secret name to avoid rate limits. Signed-off-by: Jana <[email protected]> Signed-off-by: Jana <[email protected]>
janavenkat
force-pushed
the
jana/add-image-pull-secrets
branch
from
692973b
to
0f91131
Compare
|
@rksharma95 @daemon1024 , can you please review this PR? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In larger production environments, we may get rate-limited by Docker Hub for a lot of image pulls. So, I've added an option for providing the Docker pull secret name to avoid rate limits.
Purpose of PR?:
Add option for passing docker pull secrets in helm template
Does this PR introduce a breaking change?
No
**If the changes in this PR are manually verified, list down the scenarios covered::
Using helm template
Checklist:
<type>(<scope>): <subject>