fix(bpflsm): readonly and owneronly behaviour #1578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aryan-sharma11
added a commit
to Aryan-sharma11/KubeArmor
that referenced
this pull request
Feb 29, 2024
Signed-off-by: Aryan-sharma11 <[email protected]>
Aryan-sharma11
added a commit
to Aryan-sharma11/KubeArmor
that referenced
this pull request
Mar 1, 2024
Signed-off-by: Aryan-sharma11 <[email protected]>
Fixed 2 bugs When owneronly and readonly flags are set, expected behaviour is that the owner should be allowed only read access but it seemed that owner had universal access here When readonly is set for allow policy, we did not enforce readonly on it since the code was to check for deny flag in the policy, updated the check to check for absence of write flag instead Enabled tests for the earlier failing scenarios due the bug Signed-off-by: daemon1024 <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]>
Aryan-sharma11
force-pushed
the
bpflsm-fix-readonly-owneronly
branch
2 times, most recently
from
aec81bc to
0a6bed0
Compare
Signed-off-by: Aryan-sharma11 <[email protected]>
Aryan-sharma11
force-pushed
the
bpflsm-fix-readonly-owneronly
branch
from
0a6bed0 to
9ecd20a
Compare
Signed-off-by: Aryan-sharma11 <[email protected]>
Signed-off-by: Aryan-sharma11 <[email protected]>
Aryan-sharma11
force-pushed
the
bpflsm-fix-readonly-owneronly
branch
2 times, most recently
from
068acca to
bb6fd61
Compare
Signed-off-by: Aryan-sharma11 <[email protected]>
Aryan-sharma11
force-pushed
the
bpflsm-fix-readonly-owneronly
branch
from
bb6fd61 to
6ce9da3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed 2 bugs
When owneronly and readonly flags are set, expected behaviour is that the owner should be allowed only read access but it seemed that owner had universal access here
When readonly is set for allow policy, we did not enforce readonly on it since the code was to check for deny flag in the policy, updated the check to check for absence of write flag instead
Enabled tests for the earlier failing scenarios due the bug
Purpose of PR?:
Fixes #1385
Checklist:
<type>(<scope>): <subject>