Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kube-vip): add support for volumes and hostaliases configuration #56

Merged

Conversation

acamilleri
Copy link
Contributor

@acamilleri acamilleri commented Nov 20, 2024

Add support to set additional volumes, volumeMounts and hostAliases.

I'm using KubeVIP with K3S and I need to pass the kubeconfig into the container and define 127.0.0.1 as kubernetes host aliases.

volumes:
  - hostPath:
     path: /etc/rancher/k3s/k3s.yaml
     type: File
     name: kubeconfig
     
volumeMounts:
  - mountPath: /etc/kubernetes/admin.conf
    name: kubeconfig

hostAliases:
  - hostnames:
      - kubernetes
    ip: 127.0.0.1

@acamilleri acamilleri force-pushed the feat/add-additional-values-settings branch from aceecc9 to ecb07a2 Compare November 20, 2024 14:45
@rptaylor
Copy link
Contributor

#54 seems to be working as intended so if this gets merged we should finally have an updated chart published in the helm repo. Currently the latest available is still 0.6.1.

@acamilleri
Copy link
Contributor Author

Yes, but release 0.6.3 already exist. What I'm supposed to do ? I switch the chartVersion to 0.6.2 ?

@rptaylor
Copy link
Contributor

Yes, but release 0.6.3 already exist. What I'm supposed to do ? I switch the chartVersion to 0.6.2 ?

No, the version in this MR is right. I'm saying it will be a good thing to have it merged and published because it will trigger an update. :)

@acamilleri
Copy link
Contributor Author

sorry misunderstanding ^^'

@thebsdbox thebsdbox merged commit f256955 into kube-vip:main Nov 28, 2024
3 checks passed
@acamilleri acamilleri deleted the feat/add-additional-values-settings branch November 28, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants