add configurable priorityClass for kube-vip chart #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can bump the chart version if needed. |
Signed-off-by: Ryan Taylor <[email protected]>
rptaylor
force-pushed
the
kube-vip-priorityclass
branch
from
d1daf80 to
d5886ec
Compare
|
Looks good! |
Great! I rebased #45 and #46 so they are also ready now. And we especially need #48. Are you able to merge them @thebsdbox ? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kubernetes priorityClasses are an important mechanism to ensure important pods run promptly with the required resources, especially on heavily loaded clusters.
This adds the optional ability to set a priorityClass for the kube-vip pods.
@thebsdbox could you take a look please? Thanks!