feat(kube-vip)/toBool-helper-for-cp-enable-check #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergei Waigant <[email protected]>
Signed-off-by: Sergei Waigant <[email protected]>
|
@thebsdbox Maybe you want to have a look, approve and merge? :) would appreciate to be able to use that change in my work. |
|
Looking now. |
|
I don’t really know anything about helm, but it appears there is a lot Iinting issue. |
will go through it and provide fixes accordingly! |
Signed-off-by: Sergei Waigant <[email protected]>
stupid mistake... provided a fix, that should work now |
|
Awesome! |
sergeiwaigant
deleted the
feat(kube-vip)/toBool-helper-for-cp-enable-check
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am writing Ansible Roles to setup k3s with different options like metallb and kube-vip.
One can choose then just by enablind certain features in the role to get a single or multo-node k3s cluster up an unning.
When using the helm-chart you have to be very precise to give the
cp_enableas astringand if not, the helm install will fail with an error"helm-controller 'error calling eq: invalid type for comparison'"This PR will handle that case and you will be able to give a
string,booleanorintegerto setcp_enable.