Warn when trying to use an unsupported proxy protocol #1626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightkr
commented
Nov 5, 2024
kube-client/src/client/builder.rs
Outdated
| @@ -104,14 +107,36 @@ impl TryFrom<Config> for ClientBuilder<GenericService> { | |||
| } | |||
|
|
|||
| #[cfg(feature = "http-proxy")] | |||
| Some(proxy_url) if proxy_url.scheme_str() == Some("http") => { | |||
| Some(proxy_url) if proxy_url.scheme_str() == Some(PROXY_SCHEME_HTTP) => { | |||
There was a problem hiding this comment.
I just noticed that we only support HTTP proxies (rather than HTTPS), but that's probably out of scope for this PR.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1626 +/- ##
=======================================
- Coverage 75.3% 75.3% -0.0%
=======================================
Files 82 82
Lines 7344 7348 +4
=======================================
Hits 5528 5528
- Misses 1816 1820 +4
|
Signed-off-by: Natalie Klestrup Röijezon <[email protected]>
Signed-off-by: Natalie Klestrup Röijezon <[email protected]>
nightkr
force-pushed
the
bugfix/warn-on-unsupported-proxy
branch
from
83b84a3
to
e81e3ac
Compare
clux
approved these changes
Nov 7, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's confusing when users try to use it but end up unable because they don't know about the feature flags. Especially since this also isn't super visible in the API docs (since it's typically picked up from the environment variables or the kubeconfig).