Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clippy fixes #1596

Merged
merged 2 commits into from
Oct 8, 2024
Merged

clippy fixes #1596

merged 2 commits into from
Oct 8, 2024

Conversation

clux
Copy link
Member

@clux clux commented Oct 8, 2024

CI red again from new clippy versions and new lints.

  • clippy +nightly --fix on runtime + core
  • one manual allow in runtime
  • two stray warnings (excess whitespace)

Most from cargo +nightly clippy --fix
one explicit allow because runtime has deny all.

Signed-off-by: clux <[email protected]>
@clux clux added the changelog-exclude changelog excluded prs label Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.2%. Comparing base (3c3939f) to head (664c71b).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kube-core/src/duration.rs 0.0% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1596   +/-   ##
=====================================
  Coverage   75.2%   75.2%           
=====================================
  Files         82      82           
  Lines       7334    7334           
=====================================
  Hits        5514    5514           
  Misses      1820    1820           
Files with missing lines Coverage Δ
kube-client/src/api/core_methods.rs 73.4% <ø> (ø)
kube-core/src/object.rs 86.1% <ø> (ø)
kube-runtime/src/controller/mod.rs 29.9% <ø> (ø)
kube-runtime/src/reflector/store.rs 96.9% <ø> (ø)
kube-runtime/src/scheduler.rs 94.8% <ø> (ø)
kube-runtime/src/utils/delayed_init.rs 97.1% <ø> (ø)
kube-core/src/duration.rs 60.5% <0.0%> (ø)

@clux clux marked this pull request as ready for review October 8, 2024 13:26
@clux clux requested a review from nightkr October 8, 2024 13:27
@clux clux added this to the 0.96.0 milestone Oct 8, 2024
@clux clux merged commit 6688421 into main Oct 8, 2024
18 checks passed
@clux clux deleted the clippy-fixes branch October 8, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-exclude changelog excluded prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants