Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change auth behavior to match upstream on unknown/empty user - use null auth #1595

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

aviramha
Copy link
Contributor

@aviramha aviramha commented Oct 8, 2024

change auth behavior to match upstream on unknown/empty user - use null auth
Closes #1594
Should help metalbear-co/mirrord#2803

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks sensible to me. Good find.

kube-client/src/config/file_loader.rs Show resolved Hide resolved
@clux clux added the changelog-fix changelog fix category for prs label Oct 8, 2024
@clux clux added this to the 0.96.0 milestone Oct 8, 2024
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 75.2%. Comparing base (7920fc3) to head (3f0b0d6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kube-client/src/config/file_loader.rs 0.0% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1595     +/-   ##
=======================================
- Coverage   75.3%   75.2%   -0.0%     
=======================================
  Files         82      82             
  Lines       7331    7334      +3     
=======================================
- Hits        5515    5514      -1     
- Misses      1816    1820      +4     
Files with missing lines Coverage Δ
kube-client/src/config/mod.rs 45.0% <ø> (ø)
kube-client/src/config/file_loader.rs 78.9% <0.0%> (-6.8%) ⬇️

@aviramha
Copy link
Contributor Author

aviramha commented Oct 8, 2024

Seems that nightly fails are not related to the changes.

@clux
Copy link
Member

clux commented Oct 8, 2024

Yeah, I don't know what's up with nightly here. But it's not worth worrying about atm I think.

@clux clux merged commit 3c3939f into kube-rs:main Oct 8, 2024
16 of 17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kube-rs can't use empty user like Go's kubectl can
2 participants