Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure watch_object handles objects removed before init #1577

Merged
merged 2 commits into from
Sep 13, 2024

Conversation

markdingram
Copy link
Contributor

@markdingram markdingram commented Sep 11, 2024

Stream produced by watch_object will include an item when the object isn't in any initial list

fixes #1576

Motivation

Solution

No tests! I see there are attempts already in this area underway, e.g. #1529

I would be happy to add tests if/when those tests land

@markdingram markdingram force-pushed the watch_object branch 2 times, most recently from e97bc20 to 83d81ba Compare September 11, 2024 11:36
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 92.85714% with 1 line in your changes missing coverage. Please review.

Project coverage is 75.3%. Comparing base (63644d2) to head (b49ab8c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
kube-runtime/src/watcher.rs 92.9% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1577     +/-   ##
=======================================
+ Coverage   75.3%   75.3%   +0.1%     
=======================================
  Files         82      82             
  Lines       7323    7331      +8     
=======================================
+ Hits        5511    5519      +8     
  Misses      1812    1812             
Files with missing lines Coverage Δ
kube-runtime/src/watcher.rs 44.2% <92.9%> (+2.1%) ⬆️

Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. I think this makes sense. A couple of quick questions to make sure i understand properly.

kube-runtime/src/watcher.rs Outdated Show resolved Hide resolved
kube-runtime/src/watcher.rs Show resolved Hide resolved
@clux clux added the changelog-fix changelog fix category for prs label Sep 12, 2024
@clux clux added this to the 0.94.2 milestone Sep 12, 2024
…t isn't in any initial list

fixes kube-rs#1576

Signed-off-by: Mark Ingram <[email protected]>
…t isn't in any initial list

- added a comment
- resolved a nightly clippy
- use a match guard instead of an nested if

Signed-off-by: Mark Ingram <[email protected]>
Copy link
Member

@clux clux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments are clear, thank you!

@clux clux changed the title Stream produced by watch_object will include an item when the objec… Ensure watch_object handles objects removed before init Sep 13, 2024
@clux clux merged commit 84985b4 into kube-rs:main Sep 13, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-fix changelog fix category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stream produced by "watch_object" no longer emits when an object isn't in the initial list
2 participants