-
-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tokio-tungstenite
to 0.23
#1509
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1509 +/- ##
=====================================
Coverage 75.0% 75.0%
=====================================
Files 78 78
Lines 6854 6854
=====================================
Hits 5134 5134
Misses 1720 1720 |
Cargo.toml
Outdated
tokio = "1.14.0" | ||
tokio = "1.38.0" | ||
tokio-test = "0.4.0" | ||
tokio-tungstenite = "0.21.0" | ||
tokio-tungstenite = "0.23.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
afaikt this tokio bump to 1.38 is unnecessary. it only depends on 1
https://crates.io/crates/tokio-tungstenite/0.23.0/dependencies / https://github.com/snapview/tokio-tungstenite/blob/master/Cargo.toml#L33
bumping tokio-tungstenite by itself is worth it though because that's likely what is leading to version conflicts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It also is dependant on crate.io somehow. I cannot force tokio 1.14 into my project once 1.38 has been added. Deleting lockfile and target dir does not help. However, We should not have a useless crate dependency in there that results in larger binary size, confuses cargo and leads to strange errors.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The 1.14
is mostly informational (last known feature we took from tokio came in this version) and imposes no real constraints other than >=1.14. It does not mean that you will be able to build a maximal kube + the rest of the ecosystem with 1.14, cargo should pick one satisfying the union of all transitive constraints. If you try to force 1.14 in an app, that might indeed fail.
Putting 1.38 on our end means we force every user to also upgrade tokio with the next kube release which i am not a fan of.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems I can't reproduce the dependency error anymore. So I guess it was time dependant? Maybe tokio just made a release?
Anyway updating to your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating tokio-tungstenite
is welcome regardless. Thank you.
Signed-off-by: Till Wegmüller <[email protected]>
tokio-tungstenite
to 0.23
Motivation
Fix #1508
Solution
Update tokio to 1.38.0 and keep tokio-tungstenite in sync