Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update tokio-tungstenite to 0.23 #1509

Merged
merged 1 commit into from
Jun 2, 2024
Merged

Update tokio-tungstenite to 0.23 #1509

merged 1 commit into from
Jun 2, 2024

Conversation

Toasterson
Copy link
Contributor

Motivation

Fix #1508

Solution

Update tokio to 1.38.0 and keep tokio-tungstenite in sync

Copy link

codecov bot commented Jun 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.0%. Comparing base (cdab287) to head (e4bf3e9).

Additional details and impacted files
@@          Coverage Diff          @@
##            main   #1509   +/-   ##
=====================================
  Coverage   75.0%   75.0%           
=====================================
  Files         78      78           
  Lines       6854    6854           
=====================================
  Hits        5134    5134           
  Misses      1720    1720           

see 1 file with indirect coverage changes

Cargo.toml Outdated
Comment on lines 82 to 84
tokio = "1.14.0"
tokio = "1.38.0"
tokio-test = "0.4.0"
tokio-tungstenite = "0.21.0"
tokio-tungstenite = "0.23.0"
Copy link
Member

@clux clux Jun 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

afaikt this tokio bump to 1.38 is unnecessary. it only depends on 1
https://crates.io/crates/tokio-tungstenite/0.23.0/dependencies / https://github.com/snapview/tokio-tungstenite/blob/master/Cargo.toml#L33

bumping tokio-tungstenite by itself is worth it though because that's likely what is leading to version conflicts

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It also is dependant on crate.io somehow. I cannot force tokio 1.14 into my project once 1.38 has been added. Deleting lockfile and target dir does not help. However, We should not have a useless crate dependency in there that results in larger binary size, confuses cargo and leads to strange errors.

Copy link
Member

@clux clux Jun 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 1.14 is mostly informational (last known feature we took from tokio came in this version) and imposes no real constraints other than >=1.14. It does not mean that you will be able to build a maximal kube + the rest of the ecosystem with 1.14, cargo should pick one satisfying the union of all transitive constraints. If you try to force 1.14 in an app, that might indeed fail.

Putting 1.38 on our end means we force every user to also upgrade tokio with the next kube release which i am not a fan of.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems I can't reproduce the dependency error anymore. So I guess it was time dependant? Maybe tokio just made a release?

Anyway updating to your suggestion.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updating tokio-tungstenite is welcome regardless. Thank you.

Signed-off-by: Till Wegmüller <[email protected]>
@clux clux changed the title Update tokio deps and tokio-tungstenite in sync Update tokio-tungstenite to 0.23 Jun 2, 2024
@clux clux added dependencies upgrades to dependencies changelog-change changelog change category for prs labels Jun 2, 2024
@clux clux added this to the 0.92.0 milestone Jun 2, 2024
@clux clux merged commit de3fe1e into kube-rs:main Jun 2, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-change changelog change category for prs dependencies upgrades to dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tokio Version confict with non default features that include kube-client
2 participants