ObjectList now accepts null metadata like upstream k8s does

[aviramha]

Fixes #1491

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.9%. Comparing base (3170f68) to head (4dd73a6).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #1492   +/-   ##
=====================================
  Coverage   74.9%   74.9%           
=====================================
  Files         78      78           
  Lines       6806    6806           
=====================================
  Hits        5091    5091           
  Misses      1715    1715           

Files	Coverage Δ
kube-core/src/object.rs	86.1% <ø> (ø)

[aviramha]

Not sure if the failure is my fault?

[clux]

hm, the failure seems very related:

test test::derived_resources_discoverable ... FAILED
---- test::derived_resources_discoverable stdout ----
Error: SerdeError(Error("missing field items", line: 1, column: 124))

probably the api.list call in that test in kube/src/lib.rs, but not sure why that would trigger here since you seem to be making it less strict, not more 🤔

[clux]

you could run it locally with cargo test -p kube -- derived_resources_discoverable --ignored --nocapture (edit: forgot features)

[aviramha]

Thanks, looking into it.
FWIW the command doesn't execute the tests - this seems to run it though:

cargo test --lib --workspace --exclude e2e --all-features -- derived_resources_discoverable --ignored --nocapture

[aviramha]

It worked for me locally when using docker-desktop (not when using a real cluster though)
I suspect it's a flake?

[clux]

hm. unlikely. same error on re-run (twice).

[clux]

hm, possible hunch: this is the first PR to use k3s 1.30.0 which released a few days ago

[clux]

it fails locally on k3s 1.30 with or without your change 🙃

[clux]

2024-05-13T11:31:55.936900Z  WARN kube_client::client: {"kind":"ValidatingAdmissionPolicyList","apiVersion":"admissionregistration.k8s.io/v1","metadata":{"resourceVersion":"529"}}
, Error("missing field `items`", line: 1, column: 124)
2024-05-13T11:31:55.937000Z TRACE tower::buffer::worker: buffer already closed
2024-05-13T11:31:55.937022Z TRACE mio::poll: deregistering event source from poller
Error: SerdeError(Error("missing field `items`", line: 1, column: 124))
test test::derived_resources_discoverable ... FAILED

a list on admission policies returns a list with null'd out items!

...which seems to be confirmed with kg -v=9 ValidatingAdmissionPolicy -ojson..

Response Body: {"kind":"ValidatingAdmissionPolicyList","apiVersion":"admissionregistration.k8s.io/v1","metadata":{"resourceVersion":"412"}}

[aviramha]

Ah, nice - not sure I'll be able to address the issue (bit problematic for me to setup k3s).

[clux]

Feel free to pin CI to 1.29 in integration builds for now. This is likely an upstream bug, so gotta got hunting :(

[aviramha]

just did :)

[clux]

Looks sensible to me, I'll merge in, but just out of interest, where did you encounter this? I have not seen this fail before.

[aviramha]

Our operator builds RestfulList on its own (not sure why we did tbh, maybe no existing modeling in kube-rs? or there wasn't when we needed?) and we don't populate the metadata (because it's optional)

[clux]

For future reference the missing items in ValidatingAdmissionPolicy was indeed a bug upstream and was fixed in 1.30.4

Fixed a bug in the API server where empty collections of ValidatingAdmissionPolicies did not have an items field. (kubernetes/kubernetes#126146, @xyz-li) [SIG API Machinery]

via 1.30.4 changelog

[aviramha]

For future reference the missing items in ValidatingAdmissionPolicy was indeed a bug upstream and was fixed in 1.30.4

Fixed a bug in the API server where empty collections of ValidatingAdmissionPolicies did not have an items field. (kubernetes/kubernetes#126146, @xyz-li) [SIG API Machinery]

via 1.30.4 changelog

Funny, we can open an issue to revert my PR then when 1.30.4 becomes the minimal supported version.