Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to create non-controller owner reference for resource #1475

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

Danil-Grigorev
Copy link
Member

Motivation

It is common to specify controller: false owner references on child resources which are intended to be reconciled by other controllers.

Solution

I think it makes sense to include owner_ref method for regular owner reference in addition to controller_owner_ref

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 74.6%. Comparing base (79d23a0) to head (c3c1a9b).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1475     +/-   ##
=======================================
- Coverage   74.7%   74.6%   -0.0%     
=======================================
  Files         79      79             
  Lines       6868    6871      +3     
=======================================
  Hits        5125    5125             
- Misses      1743    1746      +3     
Files Coverage Δ
kube-core/src/resource.rs 61.4% <0.0%> (-2.1%) ⬇️

@clux clux added the changelog-change changelog change category for prs label Apr 21, 2024
clux

This comment was marked as outdated.

@clux clux added this to the 0.91.0 milestone Apr 21, 2024
@Danil-Grigorev

This comment was marked as resolved.

@clux

This comment was marked as resolved.

@clux clux added changelog-add changelog added category for prs and removed changelog-change changelog change category for prs labels Apr 29, 2024
@clux
Copy link
Member

clux commented Apr 29, 2024

Sending this through. It's actually not breaking as I originally thought because we have a default impl, so re-marking as changelog-add.

@clux clux merged commit 72eef44 into kube-rs:main Apr 29, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-add changelog added category for prs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants