Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove relics of unflattened / flattened stream #1517

Closed
clux opened this issue Jun 13, 2024 · 0 comments · Fixed by #1520
Closed

Remove relics of unflattened / flattened stream #1517

clux opened this issue Jun 13, 2024 · 0 comments · Fixed by #1520
Assignees
Labels
docs unclear documentation runtime controller runtime related

Comments

@clux
Copy link
Member

clux commented Jun 13, 2024

Would you like to work on this feature?

None

What problem are you trying to solve?

Since 0.92 and in particular #1504, there is no longer any vectors being passed as watcher::Event, so there should be no need to talk about flattening, or have behaviour that references this.

Work already done:

Describe the solution you'd like

  1. Rename EventFlatten and references and turn it into an EventFilter (since that's all it does now)
  2. Clean up any other relevant references

Describe alternatives you've considered

Remove EventFlatten entirely, but having WatchStreamExt::touched_objects() and WatchStreamExt::applied_objects() go through a filter rather than a flattener seems fine to me. The method does not necessarily imply that it's flattening.

Documentation, Adoption, Migration Strategy

Need to change streams doc in kube.rs to not mention it (i can do that after)

Target crate for feature

kube-runtime

@clux clux added runtime controller runtime related docs unclear documentation labels Jun 13, 2024
@clux clux self-assigned this Jun 13, 2024
clux added a commit that referenced this issue Jun 13, 2024
@clux clux closed this as completed in #1520 Oct 4, 2024
clux added a commit that referenced this issue Oct 4, 2024
* runtime: rename references from Flatten to Filter where necessary

closes #1517

Signed-off-by: clux <[email protected]>

* file rename and rename refs to EventFlatten

Signed-off-by: clux <[email protected]>

* forgot to add missing deprecation target version

Signed-off-by: clux <[email protected]>

* make it non-breaking

Signed-off-by: clux <[email protected]>

* Update kube-runtime/src/utils/mod.rs

Co-authored-by: Matei David <[email protected]>
Signed-off-by: Eirik A <[email protected]>

* rename to event decode

Signed-off-by: clux <[email protected]>

* rename everywhere from filter to decode

Signed-off-by: clux <[email protected]>

* fix deny..

Signed-off-by: clux <[email protected]>

---------

Signed-off-by: clux <[email protected]>
Signed-off-by: Eirik A <[email protected]>
Co-authored-by: Matei David <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs unclear documentation runtime controller runtime related
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant