-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PascalCase conversion on structs in codegen #15
Comments
Mostly a clean bump one minor case overrides for #15 -> `ServiceCIDR`
As an update, here's the small list of overrides currently: k8s-pb/k8s-pb-codegen/src/main.rs Lines 198 to 227 in 0111958
This is clearly not a big problem. The only actual question here is what to do about Closing this as wontfix. |
Have undone this in #49 because it would be somewhat annoying to have to keep track of these names upstream in the event of a swithover. |
Prost also converts aggressive PascalACRONYMCase names (with allcaps somewhere inside) like
APIService
toApiService
.In general, this is a good improvement to the rust conventions, but, like #2, it has some problems:
1. have to disambiguate / break names used in kube
ApiResource
is an abstraction forAPIResource
in discovery/coreApiGroup
similarly similarly forAPIGroup
in discovery2. we break even further from official names
it's already a bit awkward that we convert their camelCased variable names to snake_case, this will also break some of the main structs.
personally, i don't really think 2. is a problem (everyone has been happy with the snake_case conversion in in k8s-openapi despite my earlier reservations), and this extra change only affects a small amount of structs who uses a decidedly bad naming convention.
The text was updated successfully, but these errors were encountered: