fix: honor stderrthreshold by disabling logtostderr default#2230
Merged
csatib02 merged 2 commits intokube-logging:masterfrom Apr 25, 2026
Merged
fix: honor stderrthreshold by disabling logtostderr default#2230csatib02 merged 2 commits intokube-logging:masterfrom
csatib02 merged 2 commits intokube-logging:masterfrom
Conversation
klog v2 defaults -logtostderr=true, which silently ignores -stderrthreshold. This adds flag.Set calls after klog.InitFlags() to disable logtostderr and enable legacy_stderr_threshold_behavior, a flag introduced in klog v2.140.0 (kubernetes/klog#432). This ensures that -stderrthreshold works as expected when configured. Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com>
|
Promptless prepared a documentation update related to this change. Triggered by this PR Added documentation for the Review: Document stderrthreshold flag |
Set legacy_stderr_threshold_behavior=false (not true) to enable the fix, and set stderrthreshold=INFO (not logtostderr=false) to preserve default behavior while allowing users to override on the command line. Signed-off-by: Pierluigi Lenoci <pierluigi.lenoci@gmail.com> Signed-off-by: Pierluigi Lenoci <pierluigilenoci@gmail.com>
csatib02
approved these changes
Apr 24, 2026
pepov
approved these changes
Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
klog v2 defaults
-logtostderr=true, which silently ignores-stderrthreshold. This means that even when operators or users set-stderrthresholdto control log routing, it has no effect.This PR adds two
flag.Setcalls immediately afterklog.InitFlags()inmain.go:logtostderr=false— disables the default that suppresses stderrthresholdlegacy_stderr_threshold_behavior=true— opts in to the fix introduced in klog v2.140.0 that restores correct stderrthreshold semanticsThe project already depends on klog v2.140.0, so no dependency changes are needed.
Which issue(s) this PR fixes
Related upstream fix: kubernetes/klog#432
Notes for reviewers
klogFlags.Set(...)pattern already used on the next line for the"v"flag