-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add Buffer to Gelf Outputs #1720
Conversation
Signed-off-by: Bartosz <[email protected]>
Signed-off-by: Bartosz <[email protected]>
Signed-off-by: Bartosz <[email protected]>
Hey @pepov, I tested it on my development environment and encountered some errors: Since the project https://github.com/hotschedules/fluent-plugin-gelf-hs is no longer maintained, I forked it and made a few changes to get it working properly. The buffer is functioning correctly, and the logs are fine. |
Can you perhaps release a gem from it? |
https://github.com/bmichalkiewicz/fluent-plugin-gelf-best you could find it in the releases |
Hey, gelf without buffor is useless, we need it so any ideas what do I need to do to replace no longer maintanced plugin with my forked ? We are extensively testing it and works like a charm |
We need to pull it into these dockerfiles to replace the originals I just didn't have the time to do this already: |
oh fine, take your time 👍 |
@bmichalkiewicz this will be available once https://github.com/kube-logging/fluentd-images/actions/runs/8878985879 has been built, with build number 139, I think we should add that image ref as a comment: |
Co-authored-by: Peter Wilcsinszky <[email protected]> Signed-off-by: Bartosz Michałkiewicz <[email protected]>
@pepov sure, commited :) |
@bmichalkiewicz sorry my suggestion broke |
I have fluentd:v1.16-full-build.140 already on dev and works as expected |
Head branch was pushed to by a user without write access
Signed-off-by: Bartosz <[email protected]>
f67d817
to
9ae3d96
Compare
@pepov |
…o spec Signed-off-by: Bartosz <[email protected]>
@pepov fixed ci test |
This PullRequest adds a buffer section to Gelf Outputs and ClusterOutputs.
This might be a bug/mistake as deployed config has a buffer section with flush_mode.