cleanup: set fluentbit buffer size to 0 using the plugin defaults, av…

…oid showing a warning

Signed-off-by: Peter Wilcsinszky <[email protected]>

docs/configuration/crds/v1beta1/fluentbit_types.md

@@ -577,9 +577,9 @@ Default: On
 
 ### Buffer_Size (string, optional) {#filterkubernetes-buffer_size}
 
-Set the buffer size for HTTP client when reading responses from Kubernetes API server. The value must be according to the Unit Size specification. A value of 0 results in no limit, and the buffer will expand as-needed. Note that if pod specifications exceed the buffer limit, the API response will be discarded when retrieving metadata, and some kubernetes metadata will fail to be injected to the logs. If this value is empty we will set it "0".
+Set the buffer size for HTTP client when reading responses from Kubernetes API server. The value must be according to the Unit Size specification. A value of 0 results in no limit, and the buffer will expand as-needed. Note that if pod specifications exceed the buffer limit, the API response will be discarded when retrieving metadata, and some kubernetes metadata will fail to be injected to the logs. If this value is empty we will set it "0". (default:"0") 
 
-Default: "0"
+Default: 0
 
 ### Cache_Use_Docker_Id (string, optional) {#filterkubernetes-cache_use_docker_id}
 

pkg/resources/fluentbit/configsecret.go

@@ -207,12 +207,6 @@ func (r *Reconciler) configSecret() (runtime.Object, reconciler.DesiredState, er
 	disableKubernetesFilter := r.fluentbitSpec.DisableKubernetesFilter != nil && *r.fluentbitSpec.DisableKubernetesFilter
 
 	if !disableKubernetesFilter {
-		if r.fluentbitSpec.FilterKubernetes.BufferSize == "" {
-			r.logger.Info("Notice: If the Buffer_Size value is empty we will set it 0. For more information: https://github.com/fluent/fluent-bit/issues/2111")
-			r.fluentbitSpec.FilterKubernetes.BufferSize = "0"
-		} else if r.fluentbitSpec.FilterKubernetes.BufferSize != "0" {
-			r.logger.Info("Notice: If the kubernetes filter buffer_size parameter is underestimated it can cause log loss. For more information: https://github.com/fluent/fluent-bit/issues/2111")
-		}
 		if r.fluentbitSpec.FilterKubernetes.K8SLoggingExclude == "" {
 			r.fluentbitSpec.FilterKubernetes.K8SLoggingExclude = "On"
 		}

pkg/sdk/logging/api/v1beta1/fluentbit_types.go

@@ -291,7 +291,7 @@ type FilterKubernetes struct {
 	// Match filtered records (default:kube.*)
 	Match string `json:"Match,omitempty" plugin:"default:kubernetes.*"`
 	// Set the buffer size for HTTP client when reading responses from Kubernetes API server. The value must be according to the Unit Size specification. A value of 0 results in no limit, and the buffer will expand as-needed. Note that if pod specifications exceed the buffer limit, the API response will be discarded when retrieving metadata, and some kubernetes metadata will fail to be injected to the logs. If this value is empty we will set it "0". (default:"0")
-	BufferSize string `json:"Buffer_Size,omitempty"`
+	BufferSize string `json:"Buffer_Size,omitempty" plugin:"default:0"`
 	// API Server end-point.
 	KubeURL string `json:"Kube_URL,omitempty" plugin:"default:https://kubernetes.default.svc:443"`
 	//	CA certificate file (default:/var/run/secrets/kubernetes.io/serviceaccount/ca.crt)