-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(swagger-ts): support nullable types #493
feat(swagger-ts): support nullable types #493
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d53d48b:
|
@all-contributors please add @raveclassic for code |
I've put up a pull request to add @raveclassic! 🎉 |
df730aa
to
5a4f7cf
Compare
@stijnvanhulle I fixed the test but it seems there's a type issue somewhere in the internals, as |
Codecov Report
@@ Coverage Diff @@
## main #493 +/- ##
=======================================
Coverage 86.35% 86.35%
=======================================
Files 106 106
Lines 6003 6003
Branches 773 774 +1
=======================================
Hits 5184 5184
Misses 818 818
Partials 1 1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Hi @stijnvanhulle, it seems something is off with E2E tests. |
Hi, can you pull in the main in to your branch? There was an issue on a previous PR but it should be fixed now. |
Hi, this PR adds support for
nullable: true
annotations for types in swagger-ts plugin. The annotation seems to be supported but there's a bug that skips creation of union type.