fix: min and max was not applied to the faker functions

.changeset/eight-baboons-hear.md

@@ -0,0 +1,5 @@
+---
+"@kubb/plugin-faker": patch
+---
+
+min and max was not applied to the faker functions

docs/changelog.md

@@ -4,6 +4,9 @@ title: Changelog
 
 # Changelog
 
+## 3.4.1
+- [`plugin-faker`](/plugins/plugin-faker): min and max was not applied to the faker functions
+
 ## 3.4.0
 - [`plugin-client`](/plugins/plugin-client): decouple URI (with params) from fetching
 - [`plugin-client`](/plugins/plugin-client): add header in response object

e2e/package.json

@@ -32,7 +32,7 @@
     "@kubb/plugin-ts": "workspace:*",
     "@kubb/plugin-zod": "workspace:*",
     "@kubb/react": "workspace:*",
-    "@tanstack/react-query": "^5.62.16",
+    "@tanstack/react-query": "^5.63.0",
     "@tanstack/solid-query": "^5.62.16",
     "@tanstack/svelte-query": "^5.62.16",
     "@tanstack/vue-query": "^5.62.16",

examples/advanced/package.json

@@ -39,7 +39,7 @@
     "@kubb/plugin-zod": "workspace:*",
     "@kubb/react": "workspace:*",
     "@tanstack/query-core": "^5.62.16",
-    "@tanstack/react-query": "^5.62.16",
+    "@tanstack/react-query": "^5.63.0",
     "@tanstack/solid-query": "^5.62.16",
     "@tanstack/svelte-query": "^5.62.16",
     "@tanstack/vue-query": "^5.62.16",

examples/advanced/petStore.yaml

@@ -714,6 +714,8 @@ components:
           type: integer
           format: int64
           example: 10
+          minLength: 3
+          maxLength: 100
         petId:
           type: integer
           format: int64

examples/advanced/src/gen/clients/axios/petService/addPet.ts

@@ -1,6 +1,6 @@
 import client from '../../../../axios-client.ts'
 import type { RequestConfig, ResponseErrorConfig } from '../../../../axios-client.ts'
-import type { AddPet405, AddPetMutationRequest, AddPetMutationResponse } from '../../../models/ts/petController/AddPet.ts'
+import type { AddPetMutationRequest, AddPetMutationResponse, AddPet405 } from '../../../models/ts/petController/AddPet.ts'
 
 export function getAddPetUrl() {
   return new URL('/pet', 'https://petstore3.swagger.io/api/v3')

examples/advanced/src/gen/mocks/createOrderFaker.ts

@@ -4,7 +4,7 @@ import { faker } from '@faker-js/faker'
 export function createOrderFaker(data?: Partial<Order>) {
   return {
     ...{
-      id: faker.number.int(),
+      id: faker.number.int({ min: 3, max: 100 }),
       petId: faker.number.int(),
       quantity: faker.number.int(),
       orderType: faker.helpers.arrayElement<any>(['foo', 'bar']),

examples/advanced/src/gen/mocks/tag/createTagFaker.ts

@@ -3,7 +3,7 @@ import { faker } from '@faker-js/faker'
 
 export function createTagTagFaker(data?: Partial<TagTag>) {
   return {
-    ...{ id: faker.number.int(), name: faker.string.alpha() },
+    ...{ id: faker.number.int({ min: 5, max: 7 }), name: faker.string.alpha() },
     ...(data || {}),
   }
 }

examples/advanced/src/gen/models/ts/Order.ts

@@ -22,6 +22,8 @@ export type OrderHttpStatusEnum = (typeof orderHttpStatusEnum)[keyof typeof orde
 
 export type Order = {
   /**
+   * @minLength 3
+   * @maxLength 100
    * @type integer | undefined, int64
    */
   id?: number

examples/advanced/src/gen/schemas/order.json

@@ -1,7 +1,7 @@
 {
   "type": "object",
   "properties": {
-    "id": { "type": "integer", "format": "int64", "example": 10 },
+    "id": { "type": "integer", "format": "int64", "example": 10, "minLength": 3, "maxLength": 100 },
     "petId": { "type": "integer", "format": "int64", "example": 198772 },
     "quantity": { "type": "integer", "format": "int32", "example": 7 },
     "orderType": { "type": "string", "enum": ["foo", "bar"] },

examples/advanced/src/gen/schemas2/order.json

@@ -1,7 +1,7 @@
 {
   "type": "object",
   "properties": {
-    "id": { "type": "integer", "format": "int64", "example": 10 },
+    "id": { "type": "integer", "format": "int64", "example": 10, "minLength": 3, "maxLength": 100 },
     "petId": { "type": "integer", "format": "int64", "example": 198772 },
     "quantity": { "type": "integer", "format": "int32", "example": 7 },
     "orderType": { "type": "string", "enum": ["foo", "bar"] },

examples/advanced/src/gen/zod/orderSchema.ts

@@ -3,7 +3,7 @@ import type { ToZod } from '@kubb/plugin-zod/utils'
 import { z } from 'zod'
 
 export const orderSchema = z.object({
-  id: z.number().int().optional(),
+  id: z.number().int().min(3).max(100).optional(),
   petId: z.number().int().optional(),
   quantity: z.number().int().optional(),
   orderType: z.enum(['foo', 'bar']).optional(),

examples/react-query/package.json

@@ -29,8 +29,8 @@
     "@kubb/plugin-react-query": "workspace:*",
     "@kubb/plugin-ts": "workspace:*",
     "@kubb/react": "workspace:*",
-    "@tanstack/react-query": "^5.62.16",
-    "@tanstack/react-query-devtools": "^5.62.16",
+    "@tanstack/react-query": "^5.63.0",
+    "@tanstack/react-query-devtools": "^5.63.0",
     "axios": "^1.7.9",
     "react": "^18.3.1",
     "react-dom": "^19.0.0",

examples/simple-single/package.json

@@ -31,7 +31,7 @@
     "@kubb/plugin-redoc": "workspace:*",
     "@kubb/plugin-ts": "workspace:*",
     "@kubb/plugin-zod": "workspace:*",
-    "@tanstack/react-query": "^5.62.16",
+    "@tanstack/react-query": "^5.63.0",
     "axios": "^1.7.9",
     "react": "^18.3.1",
     "tsup": "^8.3.5",

packages/plugin-faker/src/__snapshots__/parser.test.ts.snap

@@ -48,9 +48,9 @@ exports[`faker parse > 'nullableAdditionalProperties' 1`] = `"{}"`;
 
 exports[`faker parse > 'number' 1`] = `"faker.number.float()"`;
 
-exports[`faker parse > 'object' 1`] = `"{"firstName": faker.string.alpha(),"address": faker.string.alpha()}"`;
+exports[`faker parse > 'object' 1`] = `"{"firstName": faker.string.alpha({ length: { min: 2 } }),"address": faker.string.alpha()}"`;
 
-exports[`faker parse > 'objectAnd' 1`] = `"{"firstName": faker.string.alpha(),"age": faker.number.float(),"address": Object.assign({}, faker.string.alpha(), faker.number.float())}"`;
+exports[`faker parse > 'objectAnd' 1`] = `"{"firstName": faker.string.alpha({ length: { min: 2 } }),"age": faker.number.float({ min: 3 }),"address": Object.assign({}, faker.string.alpha(), faker.number.float())}"`;
 
 exports[`faker parse > 'objectArray' 1`] = `"{"ids": faker.helpers.multiple(() => (faker.helpers.fromRegExp(new RegExp('^[a-zA-Z0-9]{1,13}$'))), { count: { min: 3, max: 10 }}) as any}"`;
 
@@ -60,7 +60,7 @@ exports[`faker parse > 'objectEmpty' 1`] = `"{}"`;
 
 exports[`faker parse > 'objectEnum' 1`] = `"{"version": faker.helpers.arrayElement<any>(["A", "B", "C", 2])}"`;
 
-exports[`faker parse > 'objectOptional' 1`] = `"{"firstName": faker.string.alpha(),"address": faker.string.alpha()}"`;
+exports[`faker parse > 'objectOptional' 1`] = `"{"firstName": faker.string.alpha({ length: { min: 2 } }),"address": faker.string.alpha()}"`;
 
 exports[`faker parse > 'primitiveDate' 1`] = `"faker.date.anytime()"`;
 

packages/plugin-faker/src/parser.ts

@@ -256,7 +256,7 @@ export function parse({ parent, current, siblings }: SchemaTree, options: Parser
         return `"${name}": ${joinItems(
           schemas
             .sort(schemaKeywordSorter)
-            .map((schema) => parse({ parent: current, current: schema, siblings }, { ...options, canOverride: false }))
+            .map((schema) => parse({ parent: current, current: schema, siblings: schemas }, { ...options, canOverride: false }))
             .filter(Boolean),
         )}`
       })
@@ -291,9 +291,9 @@ export function parse({ parent, current, siblings }: SchemaTree, options: Parser
   }
 
   if (isKeyword(current, schemaKeywords.string)) {
-    if (parent) {
-      const minSchema = SchemaGenerator.find([parent], schemaKeywords.min)
-      const maxSchema = SchemaGenerator.find([parent], schemaKeywords.max)
+    if (siblings) {
+      const minSchema = SchemaGenerator.find(siblings, schemaKeywords.min)
+      const maxSchema = SchemaGenerator.find(siblings, schemaKeywords.max)
 
       return fakerKeywordMapper.string(minSchema?.args, maxSchema?.args)
     }
@@ -302,9 +302,9 @@ export function parse({ parent, current, siblings }: SchemaTree, options: Parser
   }
 
   if (isKeyword(current, schemaKeywords.number)) {
-    if (parent) {
-      const minSchema = SchemaGenerator.find([parent], schemaKeywords.min)
-      const maxSchema = SchemaGenerator.find([parent], schemaKeywords.max)
+    if (siblings) {
+      const minSchema = SchemaGenerator.find(siblings, schemaKeywords.min)
+      const maxSchema = SchemaGenerator.find(siblings, schemaKeywords.max)
 
       return fakerKeywordMapper.number(minSchema?.args, maxSchema?.args)
     }
@@ -313,9 +313,9 @@ export function parse({ parent, current, siblings }: SchemaTree, options: Parser
   }
 
   if (isKeyword(current, schemaKeywords.integer)) {
-    if (parent) {
-      const minSchema = SchemaGenerator.find([parent], schemaKeywords.min)
-      const maxSchema = SchemaGenerator.find([parent], schemaKeywords.max)
+    if (siblings) {
+      const minSchema = SchemaGenerator.find(siblings, schemaKeywords.min)
+      const maxSchema = SchemaGenerator.find(siblings, schemaKeywords.max)
 
       return fakerKeywordMapper.integer(minSchema?.args, maxSchema?.args)
     }

packages/plugin-ts/src/parser.ts

@@ -210,7 +210,7 @@ export function parse({ parent, current, siblings }: SchemaTree, options: Parser
         const maxSchema = schemas.find((schema) => schema.keyword === schemaKeywords.max) as SchemaKeywordMapper['max'] | undefined
         const matchesSchema = schemas.find((schema) => schema.keyword === schemaKeywords.matches) as SchemaKeywordMapper['matches'] | undefined
 
-        let type = schemas.map((schema) => parse({ parent: current, current: schema, siblings }, options)).filter(Boolean)[0] as ts.TypeNode
+        let type = schemas.map((schema) => parse({ parent: current, current: schema, siblings: schemas }, options)).filter(Boolean)[0] as ts.TypeNode
 
         if (isNullable) {
           type = factory.createUnionDeclaration({

packages/plugin-zod/src/parser.ts

@@ -285,7 +285,7 @@ export function parse({ parent, current, siblings }: SchemaTree, options: Parser
         }
 
         return `"${name}": ${sort(schemas)
-          .map((schema, array, siblings) => parse({ parent: current, current: schema, siblings }, options))
+          .map((schema, array, siblings) => parse({ parent: current, current: schema, siblings: schemas }, options))
           .filter(Boolean)
           .join('')}`
       })