[PR-Reviewer] Add null safety check to Android inset dispatch fix and correct test naming#19
Draft
[PR-Reviewer] Add null safety check to Android inset dispatch fix and correct test naming#19
Conversation
### Description of Change These integration tests are failing ``` Failed to boot simulator with UDID '\u001b[41m\u001b[30mfail\u001b[39m\u001b[22m\u001b[49m: Microsoft.DotNet.XHarness.Common.CLI.NoDeviceFoundException: Failed to find/create suitable simulator ---> Microsoft.DotNet.XHarness.Common.CLI.NoDeviceFoundException: Could not create device runtime: com.apple.CoreSimulator.SimRuntime.iOS-18-0 device type: com.apple.CoreSimulator.SimDeviceType.iPhone-XS at Microsoft.DotNet.XHarness.iOS.Shared.Hardware.SimulatorLoader.FindOrCreateDevicesAsync(ILog log, String runtime, String devicetype, Boolean force, CancellationToken cancellationToken) in //src/Microsoft.DotNet.XHarness.iOS.Shared/Hardware/SimulatorLoader.cs:line 232 at Microsoft.DotNet.XHarness.iOS.Shared.Hardware.SimulatorLoader.FindSimulators(TestTargetOs target, ILog log, Boolean createIfNeeded, Boolean minVersion, CancellationToken cancellationToken) in //src/Microsoft.DotNet.XHarness.iOS.Shared/Hardware/SimulatorLoader.cs:line 412 at Microsoft.DotNet.XHarness.iOS.Shared.Hardware.SimulatorLoader.FindSimulators(TestTargetOs target, ILog log, Int32 retryCount, Boolean createIfNeeded, Boolean minVersion, CancellationToken cancellationToken) in //src/Microsoft.DotNet.XHarness.iOS.Shared/Hardware/SimulatorLoader.cs:line 517 --- End of inner exception stack trace --- at Microsoft.DotNet.XHarness.iOS.Shared.Hardware.SimulatorLoader.FindSimulators(TestTargetOs target, ILog log, Int32 retryCount, Boolean createIfNeeded, Boolean minVersion, CancellationToken cancellationToken) in //src/Microsoft.DotNet.XHarness.iOS.Shared/Hardware/SimulatorLoader.cs:line 525 at Microsoft.DotNet.XHarness.Apple.DeviceFinder.FindDevice(TestTargetOs target, String deviceName, ILog log, Boolean includeWirelessDevices, Boolean pairedDevicesOnly, CancellationToken cancellationToken) in //src/Microsoft.DotNet.XHarness.Apple/DeviceFinder.cs:line 60 at Microsoft.DotNet.XHarness.CLI.Commands.Apple.AppleDeviceCommand.Invoke(ILogger logger) in //src/Microsoft.DotNet.XHarness.CLI/Commands/Apple/AppleDeviceCommand.cs:line 59'. Expected: True But was: False ``` Co-Authored-By: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-Authored-By: Jakub Florkowski <42434498+kubaflo@users.noreply.github.com> Co-Authored-By: Rui Marinho <me@ruimarinho.net>
Condensed and reorganized .github/agents/pr-reviewer.md to reference new modular instruction files for PR review workflow. Added core guidelines and supporting documents under .github/instructions/pr-reviewer-agent/ for time management, edge cases, error handling, output format, safe area testing, sandbox setup, and testing procedures. This improves maintainability and clarity for PR reviewer agent processes.
Co-authored-by: kubaflo <42434498+kubaflo@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Review changes in Maui pull request 32537
[PR-Reviewer] Add null safety check to Android inset dispatch fix and correct test naming
Nov 16, 2025
790e973 to
971e326
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Are you waiting for the changes in this PR to be merged?
It would be very helpful if you could test the resulting artifacts from this PR and let us know in a comment if this change resolves your issue. Thank you!
Description of Change
This PR addresses two issues found during review of PR dotnet#32537:
1. Critical Null Safety Issue
The
ViewGroupCompat.InstallCompatInsetsDispatch(_rootView)call in NavigationRootManager.cs can throw NullReferenceException when the IFlyoutView code path doesn't set_rootView. Specifically:Fix: Add null check before calling the method.
2. Test Naming Mismatch
Test files are named
Issue32278.*but PR dotnet#32537 fixes issue dotnet#32526. Issue dotnet#32278 is a different, already-merged PR about WindowInsetListener refactoring.Fix: Rename all test files from
Issue32278toIssue32526and update internal references.Changes Made
&& _rootView is not nullnull safety checkIssue32278.*→Issue32526.*and update class names, attributes, and referencesIssues Fixed
Fixes critical null safety bug in dotnet#32537
Fixes test naming mismatch in dotnet#32537
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
https://api.github.com/repos/dotnet/maui/pulls/32537/commentscurl -s -H Accept: application/vnd.github.v3+json REDACTED(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.