-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install issues with 2.2.1 #44
Comments
We are using Edit: clarify rake at system level with italics text |
Hi, I'm not a contributor, but since Rainbow affects many of my projects via RuboCop, I've been following along and doing some troubleshooting. To be clear, Rake is not required at runtime to use the rainbow gem; rather it is needed at However, to unpack this a bit further: Rainbow is simply using the Rubygems Documentation on the Builder system is hard to find, but here's is what I've pieced together:
At this final step, the installation process will fail if your Ruby installation lacks the To solve this, Rainbow needs a way to do its Windows post-install step without relying on |
The whole mess with bundler/rake/mkrf_conf in 2.2.0 and 2.2.1 is because these extra gems installed via native extension were needed under Window + Ruby 1.9 for ANSI escape codes working. We have a new PR #46 that drops Ruby 1.9.3 support (and solves these problems by doing so). |
@sickill Hello! Everything is hard. RakeBuilder patch for Rubygems: rubygems/rubygems#1819 |
I'm building a docker image from |
@sickill I was told that that PR (now merged) may go out as a backport in a rubygems v2.6.9. (It is not a new feature, so it does not need to wait for a 2.7.0.) Update: Now, 2.6.9 of Rubygems is out, with that Frozen String Literal fix, so having a |
For me, tries to use 'rake24' command, but I only have 'rake' as command. Using ruby 2.4, but rake from gem. Output:
|
My bad, I made a new gem environment and I didn't had the rake dependency on my Gemfile. Installing manually rake worked correctly. |
We've got a different error on Travis CI:
|
@jodosha I added a bit above about the 2.6.9 of Rubygems.
|
@olleolleolle That worked, thank you! 😄 |
Is there something we can do in rainbow to make it work without Rubygems 2.6.9? |
@sickill I'm not sure. I can build latest rainbow on MRI 2.4 w/ Rubygems 2.6.8 (Mac OS). |
@sickill The error is triggered when using the Rakefile-based gemspec extension. On RG versions < 2.6.9. Oh, and there are versions which are OK, which don't have the "frozen string literal" annotations. |
@Cohen-Carlisle Does the rubygems ( |
- Note that AppVeyor doesn't yet have Ruby 2.4, likely because the folks who maintain RubyInstaller haven't yet released a Windows installer for Ruby 2.4 - This PR also updates Travis to run `gem update --system` because Rubygems 2.6.9 is required to install the Rainbow gem on Ruby 2.4. There may be a better solution to this problem - this is a quick spike to detect any spec failures. ku1ik/rainbow#44
- Note that AppVeyor doesn't yet have Ruby 2.4, likely because the folks who maintain RubyInstaller haven't yet released a Windows installer for Ruby 2.4 - This PR also updates Travis to run `gem update --system` because Rubygems 2.6.9 is required to install the Rainbow gem on Ruby 2.4. There may be a better solution to this problem - this is a quick spike to detect any spec failures. ku1ik/rainbow#44
I'm still having problems here even after running
|
@timrogers Can you update your dump with notes on which Bundler you use? Do you have |
It's fine if I add |
This is recommended for the rainbow gem (rubocop dependency) See: ku1ik/rainbow#44 (comment)
For people having issues with 2.2.1 I offer the following workaround: group :workaround do
gem 'rainbow', '~>2.0', '!=2.2.1'
end |
* Fix ci build systems Update system ruby rubgems > 2.6.9 so we can install `rainbow` gem. Require `rake` in our Gemfile. Secondary bandaid for `rainbow` gem. See: ku1ik/rainbow#44 Fix: #64 * Fix svn.rb empty upstream method
Newer versions of Ruby ship with a broken version of Rubygems (2.6.8) when doing parallel installs. Fix this by updating Rubygems to a newer version (2.6.9 has the fix). See: ku1ik/rainbow#44
I have just released rainbow v2.2.2 with rake as a declared dependency (#58). Thanks for reporting and debugging guys! |
@sickill: Not entirely sure it's related, but I came across this SO question, where the OP seems to have the same issue with 2.2.2.
|
- Note that AppVeyor doesn't yet have Ruby 2.4, likely because the folks who maintain RubyInstaller haven't yet released a Windows installer for Ruby 2.4 - This PR also updates Travis to run `gem update --system` because Rubygems 2.6.9 is required to install the Rainbow gem on Ruby 2.4. There may be a better solution to this problem - this is a quick spike to detect any spec failures. ku1ik/rainbow#44
@sickill: Still having issues matching what was going on in this thread.
|
No longer need to build for ruby 2.1 and ku1ik/rainbow#44 is now resolved.
ku1ik/rainbow#44 is now resolved so we shouldn't need to call this directly.
ku1ik/rainbow#44 is now resolved so we shouldn't need to call this directly.
* Removing pinned version of mixlib-shellout No longer need to support Ruby 2.1 builds * Removing explict rake dependency ku1ik/rainbow#44 is now resolved so we shouldn't need to call this directly. * Updating Travis builds Adding support for Ruby 2.4 and updating to 2.3.4 * Update circle builds to use Ruby 2.3.4
A bug in Rubgems < 2.6.9 prevents the rainbow gem from being installed. See: ku1ik/rainbow#44
A bug in Rubgems < 2.6.9 prevents the rainbow gem from being installed. See: ku1ik/rainbow#44
Newer versions of Ruby ship with a broken version of Rubygems (2.6.8) when doing parallel installs. Fix this by updating Rubygems to a newer version (2.6.9 has the fix). See: ku1ik/rainbow#44
looks like an undeclared rake dependency
The text was updated successfully, but these errors were encountered: