Ignore leading and trailing spaces in a fuzzy filter [patch] - #129
Merged
Merged
Conversation
The Fuzzy arm of IsMatch passed the filter through as typed, so padding became a space the text had to contain: " hel" matched nothing and "hel " matched only items with a space. The filter is now trimmed first, as Glob and Regex already effectively do by splitting on whitespace. Fixes #115 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01RpyD4tJtfe5diTxv8UEw2x
|
This was referenced Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #115
Changes
IsMatchnow trims the filter (filter.AsSpan().Trim()) before callingFuzzy.Contains. Before this," hel"matched nothing and"hel "matched only items that contain a space.TextFilterMatchOptions) to a separate change, so this PR does not include it.Tests
FuzzyIsMatchIgnoresFilterPaddingchecks that"hel "," hel"and" hel\t"give the same result as"hel"for each candidate text.FuzzyFilterIgnoresFilterPaddingchecks thatFilterwith a padded fuzzy filter returns[hello world, helium, help].🤖 Generated with Claude Code
https://claude.ai/code/session_01RpyD4tJtfe5diTxv8UEw2x
Generated by Claude Code