Skip to content

[minor] Keep Vector0 magnitudes non-negative through unary minus and scalar * and / #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-edmondson merged 1 commit into from
Sep 30, 2026
Merged

[minor] Keep Vector0 magnitudes non-negative through unary minus and scalar * and / #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions ...mantics.SourceGenerators/Semantics.SourceGenerators.QuantitiesGenerator/AbsorbedDose.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,17 @@ namespace ktsu.Semantics.Quantities;
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AbsorbedDose<T> operator +(AbsorbedDose<T> left, AbsorbedDose<T> right) => Create(left.Quantity + right.Quantity);

/// <summary>Negates a <see cref="AbsorbedDose{T}"/>.</summary>
/// <summary>Scales a <see cref="AbsorbedDose{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AbsorbedDose<T> operator -(AbsorbedDose<T> value) => Create(-value.Quantity);
public static AbsorbedDose<T> operator *(AbsorbedDose<T> left, T right) => Create(Vector0Guards.EnsureNonNegative(left.Quantity * right, nameof(right)));

/// <summary>Scales a <see cref="AbsorbedDose{T}"/> by a bare number.</summary>
/// <summary>Scales a <see cref="AbsorbedDose{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AbsorbedDose<T> operator *(AbsorbedDose<T> left, T right) => Create(left.Quantity * right);
public static AbsorbedDose<T> operator *(T left, AbsorbedDose<T> right) => Create(Vector0Guards.EnsureNonNegative(left * right.Quantity, nameof(left)));

/// <summary>Scales a <see cref="AbsorbedDose{T}"/> by a bare number.</summary>
/// <summary>Divides a <see cref="AbsorbedDose{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AbsorbedDose<T> operator *(T left, AbsorbedDose<T> right) => Create(left * right.Quantity);

/// <summary>Divides a <see cref="AbsorbedDose{T}"/> by a bare number.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AbsorbedDose<T> operator /(AbsorbedDose<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(left.Quantity / right);
public static AbsorbedDose<T> operator /(AbsorbedDose<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(Vector0Guards.EnsureNonNegative(left.Quantity / right, nameof(right)));

/// <summary>Divides one <see cref="AbsorbedDose{T}"/> by another, giving the bare ratio.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
Expand Down
16 changes: 6 additions & 10 deletions ...ourceGenerators/Semantics.SourceGenerators.QuantitiesGenerator/AccelerationMagnitude.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,17 @@ namespace ktsu.Semantics.Quantities;
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AccelerationMagnitude<T> operator +(AccelerationMagnitude<T> left, AccelerationMagnitude<T> right) => Create(left.Quantity + right.Quantity);

/// <summary>Negates a <see cref="AccelerationMagnitude{T}"/>.</summary>
/// <summary>Scales a <see cref="AccelerationMagnitude{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AccelerationMagnitude<T> operator -(AccelerationMagnitude<T> value) => Create(-value.Quantity);
public static AccelerationMagnitude<T> operator *(AccelerationMagnitude<T> left, T right) => Create(Vector0Guards.EnsureNonNegative(left.Quantity * right, nameof(right)));

/// <summary>Scales a <see cref="AccelerationMagnitude{T}"/> by a bare number.</summary>
/// <summary>Scales a <see cref="AccelerationMagnitude{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AccelerationMagnitude<T> operator *(AccelerationMagnitude<T> left, T right) => Create(left.Quantity * right);
public static AccelerationMagnitude<T> operator *(T left, AccelerationMagnitude<T> right) => Create(Vector0Guards.EnsureNonNegative(left * right.Quantity, nameof(left)));

/// <summary>Scales a <see cref="AccelerationMagnitude{T}"/> by a bare number.</summary>
/// <summary>Divides a <see cref="AccelerationMagnitude{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AccelerationMagnitude<T> operator *(T left, AccelerationMagnitude<T> right) => Create(left * right.Quantity);

/// <summary>Divides a <see cref="AccelerationMagnitude{T}"/> by a bare number.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AccelerationMagnitude<T> operator /(AccelerationMagnitude<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(left.Quantity / right);
public static AccelerationMagnitude<T> operator /(AccelerationMagnitude<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(Vector0Guards.EnsureNonNegative(left.Quantity / right, nameof(right)));

/// <summary>Divides one <see cref="AccelerationMagnitude{T}"/> by another, giving the bare ratio.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
Expand Down
16 changes: 6 additions & 10 deletions ...cs.SourceGenerators/Semantics.SourceGenerators.QuantitiesGenerator/AcousticImpedance.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,21 +53,17 @@ namespace ktsu.Semantics.Quantities;
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AcousticImpedance<T> operator +(AcousticImpedance<T> left, AcousticImpedance<T> right) => Create(left.Quantity + right.Quantity);

/// <summary>Negates a <see cref="AcousticImpedance{T}"/>.</summary>
/// <summary>Scales a <see cref="AcousticImpedance{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AcousticImpedance<T> operator -(AcousticImpedance<T> value) => Create(-value.Quantity);
public static AcousticImpedance<T> operator *(AcousticImpedance<T> left, T right) => Create(Vector0Guards.EnsureNonNegative(left.Quantity * right, nameof(right)));

/// <summary>Scales a <see cref="AcousticImpedance{T}"/> by a bare number.</summary>
/// <summary>Scales a <see cref="AcousticImpedance{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AcousticImpedance<T> operator *(AcousticImpedance<T> left, T right) => Create(left.Quantity * right);
public static AcousticImpedance<T> operator *(T left, AcousticImpedance<T> right) => Create(Vector0Guards.EnsureNonNegative(left * right.Quantity, nameof(left)));

/// <summary>Scales a <see cref="AcousticImpedance{T}"/> by a bare number.</summary>
/// <summary>Divides a <see cref="AcousticImpedance{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AcousticImpedance<T> operator *(T left, AcousticImpedance<T> right) => Create(left * right.Quantity);

/// <summary>Divides a <see cref="AcousticImpedance{T}"/> by a bare number.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static AcousticImpedance<T> operator /(AcousticImpedance<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(left.Quantity / right);
public static AcousticImpedance<T> operator /(AcousticImpedance<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(Vector0Guards.EnsureNonNegative(left.Quantity / right, nameof(right)));

/// <summary>Divides one <see cref="AcousticImpedance{T}"/> by another, giving the bare ratio.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
Expand Down
16 changes: 6 additions & 10 deletions ...ics.SourceGenerators/Semantics.SourceGenerators.QuantitiesGenerator/ActivationEnergy.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,21 +54,17 @@ namespace ktsu.Semantics.Quantities;
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static ActivationEnergy<T> operator +(ActivationEnergy<T> left, ActivationEnergy<T> right) => Create(left.Quantity + right.Quantity);

/// <summary>Negates a <see cref="ActivationEnergy{T}"/>.</summary>
/// <summary>Scales a <see cref="ActivationEnergy{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static ActivationEnergy<T> operator -(ActivationEnergy<T> value) => Create(-value.Quantity);
public static ActivationEnergy<T> operator *(ActivationEnergy<T> left, T right) => Create(Vector0Guards.EnsureNonNegative(left.Quantity * right, nameof(right)));

/// <summary>Scales a <see cref="ActivationEnergy{T}"/> by a bare number.</summary>
/// <summary>Scales a <see cref="ActivationEnergy{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static ActivationEnergy<T> operator *(ActivationEnergy<T> left, T right) => Create(left.Quantity * right);
public static ActivationEnergy<T> operator *(T left, ActivationEnergy<T> right) => Create(Vector0Guards.EnsureNonNegative(left * right.Quantity, nameof(left)));

/// <summary>Scales a <see cref="ActivationEnergy{T}"/> by a bare number.</summary>
/// <summary>Divides a <see cref="ActivationEnergy{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static ActivationEnergy<T> operator *(T left, ActivationEnergy<T> right) => Create(left * right.Quantity);

/// <summary>Divides a <see cref="ActivationEnergy{T}"/> by a bare number.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static ActivationEnergy<T> operator /(ActivationEnergy<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(left.Quantity / right);
public static ActivationEnergy<T> operator /(ActivationEnergy<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(Vector0Guards.EnsureNonNegative(left.Quantity / right, nameof(right)));

/// <summary>Divides one <see cref="ActivationEnergy{T}"/> by another, giving the bare ratio.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
Expand Down
16 changes: 6 additions & 10 deletions ...Semantics.SourceGenerators/Semantics.SourceGenerators.QuantitiesGenerator/Admittance.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,21 +54,17 @@ namespace ktsu.Semantics.Quantities;
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static Admittance<T> operator +(Admittance<T> left, Admittance<T> right) => Create(left.Quantity + right.Quantity);

/// <summary>Negates a <see cref="Admittance{T}"/>.</summary>
/// <summary>Scales a <see cref="Admittance{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static Admittance<T> operator -(Admittance<T> value) => Create(-value.Quantity);
public static Admittance<T> operator *(Admittance<T> left, T right) => Create(Vector0Guards.EnsureNonNegative(left.Quantity * right, nameof(right)));

/// <summary>Scales a <see cref="Admittance{T}"/> by a bare number.</summary>
/// <summary>Scales a <see cref="Admittance{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static Admittance<T> operator *(Admittance<T> left, T right) => Create(left.Quantity * right);
public static Admittance<T> operator *(T left, Admittance<T> right) => Create(Vector0Guards.EnsureNonNegative(left * right.Quantity, nameof(left)));

/// <summary>Scales a <see cref="Admittance{T}"/> by a bare number.</summary>
/// <summary>Divides a <see cref="Admittance{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static Admittance<T> operator *(T left, Admittance<T> right) => Create(left * right.Quantity);

/// <summary>Divides a <see cref="Admittance{T}"/> by a bare number.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static Admittance<T> operator /(Admittance<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(left.Quantity / right);
public static Admittance<T> operator /(Admittance<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(Vector0Guards.EnsureNonNegative(left.Quantity / right, nameof(right)));

/// <summary>Divides one <see cref="Admittance{T}"/> by another, giving the bare ratio.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
Expand Down
16 changes: 6 additions & 10 deletions ...d/Semantics.SourceGenerators/Semantics.SourceGenerators.QuantitiesGenerator/Airspeed.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,21 +54,17 @@ namespace ktsu.Semantics.Quantities;
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static Airspeed<T> operator +(Airspeed<T> left, Airspeed<T> right) => Create(left.Quantity + right.Quantity);

/// <summary>Negates a <see cref="Airspeed{T}"/>.</summary>
/// <summary>Scales a <see cref="Airspeed{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static Airspeed<T> operator -(Airspeed<T> value) => Create(-value.Quantity);
public static Airspeed<T> operator *(Airspeed<T> left, T right) => Create(Vector0Guards.EnsureNonNegative(left.Quantity * right, nameof(right)));

/// <summary>Scales a <see cref="Airspeed{T}"/> by a bare number.</summary>
/// <summary>Scales a <see cref="Airspeed{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static Airspeed<T> operator *(Airspeed<T> left, T right) => Create(left.Quantity * right);
public static Airspeed<T> operator *(T left, Airspeed<T> right) => Create(Vector0Guards.EnsureNonNegative(left * right.Quantity, nameof(left)));

/// <summary>Scales a <see cref="Airspeed{T}"/> by a bare number.</summary>
/// <summary>Divides a <see cref="Airspeed{T}"/> by a bare number. Throws <see cref="System.ArgumentException"/> when the number is negative.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static Airspeed<T> operator *(T left, Airspeed<T> right) => Create(left * right.Quantity);

/// <summary>Divides a <see cref="Airspeed{T}"/> by a bare number.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
public static Airspeed<T> operator /(Airspeed<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(left.Quantity / right);
public static Airspeed<T> operator /(Airspeed<T> left, T right) => T.IsZero(right) ? throw new System.DivideByZeroException("Cannot divide by zero.") : Create(Vector0Guards.EnsureNonNegative(left.Quantity / right, nameof(right)));

/// <summary>Divides one <see cref="Airspeed{T}"/> by another, giving the bare ratio.</summary>
[System.Diagnostics.CodeAnalysis.SuppressMessage("Usage", "CA2225:Operator overloads have named alternates", Justification = "Physics quantity operator")]
Expand Down
Loading
Loading