Return snapshots from GetAllChords and BoundCommands - #130
Merged
Merged
Conversation
Profile.GetAllChords() wrapped the live chord dictionary and BoundCommands exposed its key collection, so a returned value changed after later binds and binding while iterating threw "Collection was modified". Both now copy, matching the other collection getters in the API. Fixes #127 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01G89GFC9HBcemu37GarNas1
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127
What changed
Profile.GetAllChords()returnedChords.AsReadOnly(), a wrapper over the live dictionary, andProfile.BoundCommandsreturnedChords.Keys. So a value handed to the caller changed after a laterBindChord/UnbindChord, and binding while iteratingGetAllChords()threwInvalidOperationException: Collection was modified.Both now return copies (
new Dictionary<,>(Chords).AsReadOnly()and[.. Chords.Keys]). That matches the other collection getters (GetAllProfiles,GetAllCommands), which already return snapshots.KeybindingService.GetAllChords()andGetAllChords(profileId)pass the profile's result through, so they get the fix too.Tests
New
GetAllChordsSnapshotTests:GetAllChords()/GetAllChords("p")doesn't change after a later bind and unbindGetAllChords()doesn't throwBoundCommandsdoesn't change after a later bindAll three fail on
mainand pass with the fix. The full suite passes: 90/90.🤖 Generated with Claude Code
https://claude.ai/code/session_01G89GFC9HBcemu37GarNas1
Generated by Claude Code