Keep the action's stack trace when RethrowExceptions rethrows [patch] - #62
Merged
matt-edmondson merged 1 commit intoSep 28, 2026
Merged
Conversation
TryRun and RethrowExceptions rethrew the action's exception with `throw ex`, which reset its StackTrace so it began at RethrowExceptions. Rethrow through ExceptionDispatchInfo instead, as Invoker does since ktsu-dev/Invoker#54. Fixes #58 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_013xQ2dceFuWS8VLEn2xLuZE
|
This was referenced Sep 27, 2026
matt-edmondson
deleted the
claude/intervalaction-58-rethrow-stack-trace
branch
September 28, 2026 01:34
This was referenced Sep 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #58
What changed
TryRun()andRethrowExceptions()rethrew the action's exception withthrow ex. That overwrote the exception'sStackTrace, so the trace began atRethrowExceptionsand left out the frames of the action that failed. Both sites now useExceptionDispatchInfo.Capture(ex).Throw(), the fix ktsu-dev/Invoker#54 used for the same problem. The exception type and message do not change.Test
Added
RethrowExceptionsKeepsTheActionStackTrace. The action throws from a named method, and the test asserts that the trace of the exception caught fromRethrowExceptions()contains that method's name.IntervalAction.RethrowExceptions().🤖 Generated with Claude Code
https://claude.ai/code/session_013xQ2dceFuWS8VLEn2xLuZE
Generated by Claude Code