Repository navigation
Report node size changes made while the node editor is zoomed - #637
Merged
Merged
Conversation
A node whose content grew at a zoom other than 1 kept its old size in the engine, so FitToView centred on stale sizes. A change of zoom alone is still never read as a resize; a measurement that changes while the zoom holds is reported scaled back, and corrected once the view is at its own scale. Fixes #636 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Nmg4pHCiNuGWLdXBSa6Njj
|
This was referenced Oct 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
Before: a node that grew or shrank while the canvas was zoomed kept its old size in the engine until the view returned to zoom 1, so
FitToViewcentred on stale sizes and cut off nodes that grew.After: a measurement that changes while the zoom holds still is reported, scaled back by the zoom, and replaced by the exact size the next time the view is at its own scale. A change of zoom alone is still never read as a resize, so zooming never re-spaces the graph.
How:
GetNodeDimensionUpdatesremembers, per node, the measurement, the zoomRenderdrew it at, and the size last reported. A different zoom only updates the memory (reporting the exact size at zoom 1 if it differs); the same zoom with a different measurement is a content change. NewZoomTestscover a node that grows while zoomed (fails without the fix) and the correction at zoom 1.Fixes #636
🤖 Generated with Claude Code
https://claude.ai/code/session_01Nmg4pHCiNuGWLdXBSa6Njj
Generated by Claude Code