Repository navigation
Stop a divider handle taking clicks meant for a popup over it - #613
Merged
Merged
Conversation
DividerContainer hit-tests its handles by rectangle, so a combo list or any window opened over a divider had its clicks taken by the handle, which started a resize and moved what the click was meant for. The handle now only counts as hovered when the container's own window hierarchy is hovered, popups excluded, or while it is being dragged. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0136MhikNVkWEjSYvJu2ahj7
|
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matt · project thread
Before: a combo list, popup or window opened over a
DividerContainer's divider couldn't be clicked where it covered the divider. The handle hit-tests by rectangle, so it took the click, started a resize, and moved what the click was meant for. In ImageGui this broke picking Color Balance from the Add adjustment list once the list grew long enough to open upward over the layers/inspector divider (ktsu-dev/ImageGui#144).After: the handle only counts as hovered when the container's own window hierarchy is hovered (
IsWindowHovered(ChildWindows | NoPopupHierarchy), so popups opened from a zone don't count), or while it is already being dragged.How: one condition in
DrawDividerHandle, plusDividerContainer_AClickOnAPopupOverTheHandle_DoesNotResize, which opens a popup from a zone over the handle and clicks it. It fails without the fix and passes with it. The whole widget UI suite (712) passes locally.🤖 Generated with Claude Code
https://claude.ai/code/session_0136MhikNVkWEjSYvJu2ahj7
Generated by Claude Code