Repository navigation
[patch] Draw HTML entities in Markdown as their characters, not a type name - #605
Merged
Merged
Conversation
…e name InlineBuilder had no case for Markdig's HtmlEntityInline, so "&", "©" and every other entity fell into the default branch, which emitted inline.ToString() and drew "Markdig.Syntax.Inlines.HtmlEntityInline". Entities now emit their transcoded text with the current emphasis and link, and the default branch drops an unknown leaf instead of drawing its type name. Fixes #479 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0176ydtLncnCjKchHXEPCh7H
|
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #479
What changed
ImGui.Markdown/Rendering/InlineBuilder.cs:HtmlEntityInlinecase. It emitsentity.Transcodedwith the current emphasis role and link URL, soTom & JerrydrawsTom & Jerry.default:no longer callsinline.ToString(). Markdig inlines don't overrideToString(), so that branch could only ever draw a CLR type name. It now drops the unknown leaf. Container inlines are still walked by the existingContainerInlinecase above it.Tests
Three new tests in
tests/ImGui.Markdown.Tests/InlineBuilderTests.cs:&)©)**a < b**), which keeps the bold role and draws noMarkdigtype nameAll three fail with the
InlineBuilder.cschange reverted. The fullImGui.Markdown.Testsproject passes: 42/42.🤖 Generated with Claude Code
https://claude.ai/code/session_0176ydtLncnCjKchHXEPCh7H
Generated by Claude Code