Skip to content

Replace SixLabors.ImageSharp with a self-contained image decoder - #358

Merged
matt-edmondson merged 5 commits into
mainfrom
claude/imguiapp-issue-354-7ftjju
Sep 8, 2026
Merged

matt-edmondson merged 5 commits into
mainfrom
claude/imguiapp-issue-354-7ftjju

Merge remote-tracking branch 'origin/main' into claude/imguiapp-issue…

78dde73
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Sep 8, 2026 in 1m 7s

Annotations

Check warning on line 76 in tests/ImGui.App.Tests/Images/ImageResamplerTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'Assert.IsLessThanOrEqualTo' instead of 'Assert.IsTrue'

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR4jykcv3kTz9mo0&open=AaB_VR4jykcv3kTz9mo0&pullRequest=358

Check warning on line 628 in ImGui.App/Images/JpegDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 8 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6aykcv3kTz9mpQ&open=AaB_VR6aykcv3kTz9mpQ&pullRequest=358

Check warning on line 129 in tests/ImGui.App.Tests/Images/JpegDecoderTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'Assert.IsLessThanOrEqualTo' instead of 'Assert.IsTrue'

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR4zykcv3kTz9mo9&open=AaB_VR4zykcv3kTz9mo9&pullRequest=358

Check warning on line 32 in tests/ImGui.App.Tests/Images/ImageResamplerTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'Assert.AreSequenceEqual' instead of 'CollectionAssert.AreEqual'

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR4jykcv3kTz9moz&open=AaB_VR4jykcv3kTz9moz&pullRequest=358

Check warning on line 301 in ImGui.App/Images/PngDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Method has 13 parameters, which is greater than the 7 authorized.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6Nykcv3kTz9mpK&open=AaB_VR6Nykcv3kTz9mpK&pullRequest=358

Check warning on line 39 in ImGui.App/Images/ImageDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6Cykcv3kTz9mpF&open=AaB_VR6Cykcv3kTz9mpF&pullRequest=358

Check failure on line 362 in ImGui.App/Images/PngDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6Nykcv3kTz9mpH&open=AaB_VR6Nykcv3kTz9mpH&pullRequest=358

Check warning on line 153 in ImGui.App/Images/ImageResampler.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR55ykcv3kTz9mpC&open=AaB_VR55ykcv3kTz9mpC&pullRequest=358

Check failure on line 1131 in ImGui.App/Images/JpegDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 19 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6aykcv3kTz9mpN&open=AaB_VR6aykcv3kTz9mpN&pullRequest=358

Check failure on line 51 in ImGui.App/Images/TgaDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 47 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6jykcv3kTz9mpV&open=AaB_VR6jykcv3kTz9mpV&pullRequest=358

Check warning on line 1030 in ImGui.App/Images/JpegDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6aykcv3kTz9mpU&open=AaB_VR6aykcv3kTz9mpU&pullRequest=358

Check failure on line 106 in ImGui.App/Images/JpegDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this method to not shadow the outer class' member with the same name.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6aykcv3kTz9mpL&open=AaB_VR6aykcv3kTz9mpL&pullRequest=358

Check warning on line 128 in tests/ImGui.App.Tests/Images/JpegDecoderTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'Assert.IsLessThanOrEqualTo' instead of 'Assert.IsTrue'

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR4zykcv3kTz9mo8&open=AaB_VR4zykcv3kTz9mo8&pullRequest=358

Check failure on line 567 in ImGui.App/Images/JpegDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 32 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6aykcv3kTz9mpP&open=AaB_VR6aykcv3kTz9mpP&pullRequest=358

Check warning on line 85 in tests/ImGui.App.Tests/Images/JpegDecoderTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'Assert.IsLessThan' instead of 'Assert.IsTrue'

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR4zykcv3kTz9mo5&open=AaB_VR4zykcv3kTz9mo5&pullRequest=358

Check warning on line 81 in tests/ImGui.App.Tests/Images/ImagePixelsTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'Assert.AreSequenceEqual' instead of 'CollectionAssert.AreEqual'

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR1Tykcv3kTz9moy&open=AaB_VR1Tykcv3kTz9moy&pullRequest=358

Check warning on line 951 in ImGui.App/Images/JpegDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6aykcv3kTz9mpS&open=AaB_VR6aykcv3kTz9mpS&pullRequest=358

Check warning on line 39 in ImGui.App/Images/ImageDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6Cykcv3kTz9mpD&open=AaB_VR6Cykcv3kTz9mpD&pullRequest=358

Check failure on line 94 in ImGui.App/Images/ImageResampler.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 18 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR55ykcv3kTz9mpB&open=AaB_VR55ykcv3kTz9mpB&pullRequest=358

Check warning on line 133 in ImGui.App/Images/ImagePixels.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this argument from the method call; it hides the caller information.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR5xykcv3kTz9mo_&open=AaB_VR5xykcv3kTz9mo_&pullRequest=358

Check warning on line 39 in ImGui.App/Images/ImageDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Extract this nested ternary operation into an independent statement.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6Cykcv3kTz9mpE&open=AaB_VR6Cykcv3kTz9mpE&pullRequest=358

Check failure on line 253 in ImGui.App/Images/JpegDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this method to not shadow the outer class' member with the same name.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6aykcv3kTz9mpM&open=AaB_VR6aykcv3kTz9mpM&pullRequest=358

Check warning on line 149 in tests/ImGui.App.Tests/Images/PngDecoderTests.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'Assert.AreSequenceEqual' instead of 'CollectionAssert.AreEqual'

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR4rykcv3kTz9mo4&open=AaB_VR4rykcv3kTz9mo4&pullRequest=358

Check failure on line 954 in ImGui.App/Images/JpegDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 17 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6aykcv3kTz9mpT&open=AaB_VR6aykcv3kTz9mpT&pullRequest=358

Check failure on line 786 in ImGui.App/Images/JpegDecoder.cs

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this method to reduce its Cognitive Complexity from 35 to the 15 allowed.

See more on https://sonarcloud.io/project/issues?id=ktsu-dev_ImGuiApp&issues=AaB_VR6aykcv3kTz9mpR&open=AaB_VR6aykcv3kTz9mpR&pullRequest=358