fix: make Join(items, separator, nullItemHandling) reject a null separator [patch]

Extensions.Test/EnumerableExtensionsTests.cs

@@ -340,6 +340,21 @@ public void JoinThrowsArgumentNullExceptionWhenSeparatorIsNull()
 		Assert.ThrowsExactly<ArgumentNullException>(() => items.Join(separator));
 	}
 
+	[TestMethod]
+	[DataRow(NullItemHandling.Remove)]
+	[DataRow(NullItemHandling.Include)]
+	[DataRow(NullItemHandling.Throw)]
+	public void JoinWithNullItemHandlingThrowsArgumentNullExceptionWhenSeparatorIsNull(NullItemHandling nullItemHandling)
+	{
+		// Arrange
+		List<string> items = ["a", "b", "c"];
+		string separator = null!;
+
+		// Act & Assert
+		ArgumentNullException exception = Assert.ThrowsExactly<ArgumentNullException>(() => items.Join(separator, nullItemHandling));
+		Assert.AreEqual("separator", exception.ParamName);
+	}
+
 	[TestMethod]
 	public void JoinWithNullItemHandlingRemoveRemovesNullItems()
 	{

Extensions/EnumerableExtensions.cs

@@ -30,7 +30,7 @@
 #pragma warning disable KTSU0004 // Use Ensure.NotNull instead of manual null check
 		if (items is null)
 		{
 			throw new ArgumentNullException(nameof(items), "Items cannot be null.");
 		}
 #pragma warning restore KTSU0004 // Use Ensure.NotNull instead of manual null check
 
@@ -203,7 +203,7 @@
 
 		if (nullItemHandling is NullItemHandling.Throw)
 		{
 			if (items.AnyNull())
 			{
 				throw new InvalidOperationException("The enumerable contains a null item.");
 			}
@@ -259,9 +259,16 @@
 		}
 #pragma warning restore KTSU0004 // Use Ensure.NotNull instead of manual null check
 
+#pragma warning disable KTSU0004 // Use Ensure.NotNull instead of manual null check
+		if (separator is null)
+		{
+			throw new ArgumentNullException(nameof(separator), "Separator cannot be null.");
+		}
+#pragma warning restore KTSU0004 // Use Ensure.NotNull instead of manual null check
+
 		if (nullItemHandling is NullItemHandling.Throw)
 		{
 			if (items.AnyNull())
 			{
 				throw new InvalidOperationException("The enumerable contains a null item.");
 			}