Skip to content

Read ReplaceWith's new items before clearing the collection #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matt-edmondson merged 1 commit into from
Sep 26, 2026
Merged

Read ReplaceWith's new items before clearing the collection #133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions Extensions.Test/CollectionExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -239,4 +239,24 @@

CollectionAssert.AreEqual(new List<string?> { "x", null, "z" }, collection);
}

[TestMethod]
public void ReplaceWithLazyQueryOverSameCollectionKeepsMatchingItems()
{
List<int> collection = [1, 2, 3, 4];

collection.ReplaceWith(collection.Where(x => x > 2));

CollectionAssert.AreEqual(new List<int> { 3, 4 }, collection);

Check warning on line 250 in Extensions.Test/CollectionExtensionsTests.cs

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use 'Assert.AreSequenceEqual' instead of 'CollectionAssert.AreEqual' 


See more on https://sonarcloud.io/project/issues?id=ktsu-dev_Extensions&issues=AaDcN5dFmEp5MbUoQb-Q&open=AaDcN5dFmEp5MbUoQb-Q&pullRequest=133
}

[TestMethod]
public void ReplaceWithSameCollectionKeepsItems()
{
List<int> collection = [1, 2, 3];

collection.ReplaceWith(collection);

CollectionAssert.AreEqual(new List<int> { 1, 2, 3 }, collection);

Check warning on line 260 in Extensions.Test/CollectionExtensionsTests.cs

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use 'Assert.AreSequenceEqual' instead of 'CollectionAssert.AreEqual' 


See more on https://sonarcloud.io/project/issues?id=ktsu-dev_Extensions&issues=AaDcN5dFmEp5MbUoQb-R&open=AaDcN5dFmEp5MbUoQb-R&pullRequest=133
}
}
4 changes: 3 additions & 1 deletion Extensions/CollectionExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ public static void ReplaceWith<T>(this ICollection<T> oldItems, IEnumerable<T> n
}
#pragma warning restore KTSU0004 // Use Ensure.NotNull instead of manual null check

// Materialize first: newItems may be the collection itself or a lazy query over it, which Clear would empty
T[] snapshot = [.. newItems];
oldItems.Clear();
oldItems.AddFrom(newItems);
oldItems.AddFrom(snapshot);
}
}
Loading