Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade to golang 1.20 #633

Merged
merged 4 commits into from
Feb 25, 2023
Merged

Upgrade to golang 1.20 #633

merged 4 commits into from
Feb 25, 2023

Conversation

Smirl
Copy link
Contributor

@Smirl Smirl commented Feb 7, 2023 •
edited
Loading

Summary

  • fixes /etc/resolver is not respected on MacOS #632
  • upgrades go version to 1.20 in:
    • go.mod
    • Dockerfile
    • github workflow
    • README
  • run go mod tidy for good measure.
  • run `golangci-lint
    • had to fix 4 bugs
    • grpc.WithInsecure is deprecated
    • creds.OverrideServerName is deprecated
    • grpc. NewClient is deprecated
      • Should look into this future PRs as I currently kept the same v1alpha1 support. Larger changes were needed to support v1

ktr0731
ktr0731 approved these changes Feb 25, 2023
View reviewed changes
Copy link
Owner

@ktr0731 ktr0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you!

@codecov
Copy link

codecov bot commented Feb 25, 2023 •
edited
Loading

Codecov Report

Merging #633 (7e49d78) into master (5ed4a07) will increase coverage by 0.07%.
The diff coverage is 100.00%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #633      +/-   ##
==========================================
+ Coverage   80.01%   80.09%   +0.07%     
==========================================
  Files          57       57              
  Lines        3858     3858              
==========================================
+ Hits         3087     3090       +3     
+ Misses        542      540       -2     
+ Partials      229      228       -1

@ktr0731 ktr0731 merged commit 2799931 into ktr0731:master Feb 25, 2023
@Smirl Smirl deleted the golang-1.20 branch April 18, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ktr0731 ktr0731 ktr0731 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/etc/resolver is not respected on MacOS
2 participants
@Smirl @ktr0731