Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use functional option for cui #174

Merged
merged 1 commit into from
Apr 20, 2019
Merged

Conversation

micnncim
Copy link
Contributor

@micnncim micnncim commented Apr 19, 2019

Thanks for a great tool.
I believe that using the functional option pattern makes cui.UI initialization more extensible.
And maybe the arg nil for app.New is not best solution, right?
If you check out a piece of code and feel pleased, please take this in.

ref

@codecov
Copy link

codecov bot commented Apr 19, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@d48f2bd). Click here to learn what that means.
The diff coverage is 100%.

@@            Coverage Diff            @@
##             master     #174   +/-   ##
=========================================
  Coverage          ?   66.46%           
=========================================
  Files             ?       54           
  Lines             ?     2496           
  Branches          ?        0           
=========================================
  Hits              ?     1659           
  Misses            ?      697           
  Partials          ?      140

Copy link
Owner

@ktr0731 ktr0731 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting a PR, LGTM 👍

@ktr0731 ktr0731 merged commit bb4d6df into ktr0731:master Apr 20, 2019
@micnncim micnncim deleted the update-cui-new branch April 20, 2019 03:14
ktr0731 pushed a commit that referenced this pull request May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants