KTOR-7734 JS: Catch error on channel reader closure #4641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
commented
Jan 31, 2025
| throw cause | ||
| } | ||
| }.channel | ||
|
|
||
| internal suspend fun ReadableStreamDefaultReader<Uint8Array>.readChunk(): Uint8Array? = | ||
| suspendCancellableCoroutine { continuation -> | ||
| suspendCoroutine { continuation -> |
There was a problem hiding this comment.
Made this coroutine non-cancellable to ensure the exception thrown on controller.abort() is propagated to the upper level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Client (JS/WasmJS)
Motivation
KTOR-7734 "AbortError: BodyStreamBuffer was aborted" error when canceling parent job
Solution
Solution in #4629 wasn’t correct.
The actual root cause of the issue was an uncaught exception thrown inside a
Promisereturned byreader.cancel(). Added catching for this exception and reformatted code a bit.It's better to review these two commits separately.