KTOR-8051 Revert EOFException change #4627
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
approved these changes
Jan 27, 2025
osipxd
force-pushed
the
bjhham/eof-exception
branch
from
9add2a6 to
749074c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Core, I/O
Motivation
Reverts the change in #4619 that removes these exceptions. My original assumption is that the closed channel exception would make more sense to throw since it's consistent with the rest of the library and contains some more context, but I found some websocket client code that relies on this behaviour, so it'd be best to keep this as is.
Solution
Rolled back this change, but with an extra check to ensure readFully with empty bounds is a no-op.