KTOR-6709 Fix URLParserException on minimal file url #4622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e5l
approved these changes
Jan 24, 2025
|
Hey @adriandieter. Thank you for the PR, LGTM |
adriandieter
force-pushed
the
KTOR-6709-parse-file-url
branch
from
fa06c78 to
f5444f4
Compare
|
@adriandieter, could you rebase this PR one more time, please? I'm going to merge it |
auto-merge was automatically disabled
January 28, 2025 10:24
Head branch was pushed to by a user without write access
adriandieter
force-pushed
the
KTOR-6709-parse-file-url
branch
from
f5444f4 to
3493b11
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subsystem
Core, ktor-http
Motivation
Resolves KTOR-6709 Fail to parse url: file:/path/to/file.txt. URLParser does not support file urls with a single leading
/.Solution
Add when clause to
URLBuilder.parseFileforextension function to match a single leading slash.It sets the host to empty string and the rest of the url as encodedPath.
Does not modify how URLBuilders
toString()is implemented. Leading toUrl("file:/var/www").toString()returning"file:///var/www".