KTOR-6501 Add feedback link to KDocs #4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
osipxd
reviewed
Dec 4, 2024
ktor-client/ktor-client-android/jvm/src/io/ktor/client/engine/android/Android.kt
Outdated
Show resolved
Hide resolved
e5l
force-pushed
the
e5l/kdocs-feedback-link
branch
from
71c1a56 to
30d5fdc
Compare
osipxd
reviewed
Dec 4, 2024
e5l
force-pushed
the
e5l/kdocs-feedback-link
branch
from
30d5fdc to
1011d91
Compare
osipxd
reviewed
Dec 9, 2024
e5l
force-pushed
the
e5l/kdocs-feedback-link
branch
from
1011d91 to
f6ae7af
Compare
osipxd
reviewed
Jan 28, 2025
ktor-client/ktor-client-cio/common/src/io/ktor/client/engine/cio/CIOEngineConfig.kt
Show resolved
Hide resolved
|
It would be real cool if we could generate this through some KDoc extension instead of adding it everywhere in the code. |
|
Looks like you've incurred the wrath of CodeStyle for touching all the files 😄 |
|
@bjhham it is better to have it in the source code, cause the link will also be available through quick help of IDE |
e5l
force-pushed
the
e5l/kdocs-feedback-link
branch
2 times, most recently
from
4c710ae to
a5bf930
Compare
bjhham
approved these changes
Jan 31, 2025
e5l
force-pushed
the
e5l/kdocs-feedback-link
branch
from
a5bf930 to
5822465
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://youtrack.jetbrains.com/issue/KTOR-6501