KTOR-7299 Fix close race condition causing descriptor to be closed wh…

…ile select is still busy (#4638)
ktorio · Jan 31, 2025 · 255ce5e · 255ce5e
1 parent 55106bc
commit 255ce5e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/ktor-network/nix/src/io/ktor/network/selector/SelectUtilsNix.kt b/ktor-network/nix/src/io/ktor/network/selector/SelectUtilsNix.kt
@@ -62,11 +62,11 @@ internal actual class SelectorHelper {
 
     actual fun requestTermination() {
         interestQueue.close()
-        closeQueue.close()
         wakeupSignal.signal()
     }
 
     private fun cleanup() {
+        closeQueue.close()
         while (true) {
             val event = closeQueue.removeFirstOrNull() ?: break
             closeDescriptor(event)

diff --git a/ktor-network/windows/src/io/ktor/network/selector/SelectUtilsWindows.kt b/ktor-network/windows/src/io/ktor/network/selector/SelectUtilsWindows.kt
@@ -43,11 +43,11 @@ internal actual class SelectorHelper {
 
     actual fun requestTermination() {
         interestQueue.close()
-        closeQueue.close()
         wakeupSignal.signal()
     }
 
     private fun cleanup() {
+        closeQueue.close()
         while (true) {
             val event = closeQueue.removeFirstOrNull() ?: break
             closeDescriptor(event)