Skip to content
This repository was archived by the owner on Jul 9, 2022. It is now read-only.

Collect frontend code coverage from Cypress tests#31

Closed
ktmud wants to merge 3 commits intomasterfrom
cypress-coverage
Closed

Collect frontend code coverage from Cypress tests#31
ktmud wants to merge 3 commits intomasterfrom
cypress-coverage

Conversation

@ktmud
Copy link
Owner

@ktmud ktmud commented Apr 14, 2020

CATEGORY

  • Build / Development Environment

SUMMARY

Collect frontend code coverage from Cypress tests and add proper tagging for coverage reports.

With this, we can finally start to take code coverage numbers more seriously.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

N/A

REVIEWERS

@ktmud ktmud force-pushed the cypress-coverage branch 2 times, most recently from bb502ac to 87f6133 Compare April 15, 2020 01:41
@codecov
Copy link

codecov bot commented Apr 15, 2020

Codecov Report

Merging #31 into master will increase coverage by 4.80%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
+ Coverage   65.49%   70.30%   +4.80%     
==========================================
  Files         571      571              
  Lines       29889    29889              
  Branches     3066     3040      -26     
==========================================
+ Hits        19577    21013    +1436     
+ Misses      10128     8765    -1363     
+ Partials      184      111      -73     
Flag Coverage Δ
#cypress 53.54% <ø> (?)
#javascript 58.77% <ø> (ø)
#mysql ?
#postgres ?
#python 70.24% <ø> (ø)
#sqlite ?
#unittest ?
Impacted Files Coverage Δ
...rontend/src/SqlLab/components/AceEditorWrapper.tsx 56.98% <0.00%> (+1.07%) ⬆️
superset-frontend/src/components/EditableTitle.jsx 81.69% <0.00%> (+1.40%) ⬆️
...perset-frontend/src/components/CopyToClipboard.jsx 36.36% <0.00%> (+1.51%) ⬆️
...hboard/components/resizable/ResizableContainer.jsx 71.87% <0.00%> (+1.56%) ⬆️
...ashboard/components/gridComponents/ChartHolder.jsx 81.35% <0.00%> (+1.69%) ⬆️
superset-frontend/src/utils/common.js 69.64% <0.00%> (+1.78%) ⬆️
...src/explore/components/controls/VizTypeControl.jsx 78.84% <0.00%> (+1.92%) ⬆️
...rset-frontend/src/explore/components/SaveModal.jsx 94.73% <0.00%> (+2.10%) ⬆️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx 55.12% <0.00%> (+2.56%) ⬆️
...end/src/dashboard/components/dnd/DragDroppable.jsx 97.29% <0.00%> (+2.70%) ⬆️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b11b44...e6c7c55. Read the comment docs.

@ktmud ktmud force-pushed the cypress-coverage branch 21 times, most recently from aeaeab2 to f26df73 Compare April 15, 2020 09:00
@ktmud ktmud force-pushed the cypress-coverage branch 5 times, most recently from 8d9cc20 to dee573f Compare April 15, 2020 20:32
Repository owner deleted a comment from cypress bot Apr 16, 2020
Repository owner deleted a comment from cypress bot Apr 16, 2020
@ktmud ktmud force-pushed the cypress-coverage branch 5 times, most recently from 840cad3 to 4ea4292 Compare April 16, 2020 06:09
Repository owner deleted a comment from cypress bot Apr 16, 2020
@ktmud ktmud force-pushed the cypress-coverage branch 5 times, most recently from cf3c383 to 9d1e3a3 Compare April 16, 2020 08:22
Repository owner deleted a comment from cypress bot Apr 16, 2020
Repository owner deleted a comment from cypress bot Apr 16, 2020
Repository owner deleted a comment from cypress bot Apr 16, 2020
@cypress
Copy link

cypress bot commented Apr 16, 2020



Test summary

28 0 10 0


Run details

Project Superset
Status Passed
Commit e6c7c55
Started Apr 16, 2020 7:36 PM
Ended Apr 16, 2020 7:40 PM
Duration 03:31 💡
OS Linux Ubuntu Linux - 18.04
Browser Chrome 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@cypress
Copy link

cypress bot commented Apr 16, 2020



Test summary

28 0 10 0


Run details

Project Superset
Status Passed
Commit 207aa4ed38 ℹ️
Started Apr 16, 2020 7:37 PM
Ended Apr 16, 2020 7:41 PM
Duration 03:52 💡
OS Linux Ubuntu Linux - 18.04
Browser Chrome 80

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@ktmud ktmud force-pushed the cypress-coverage branch 6 times, most recently from 33b588a to 6697207 Compare April 16, 2020 19:18
@ktmud ktmud force-pushed the cypress-coverage branch from 6697207 to e6c7c55 Compare April 16, 2020 19:32
@ktmud ktmud closed this May 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant