Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: Throws on commas #69

Closed
cmeeren opened this issue Jan 24, 2023 · 2 comments · Fixed by #79
Closed

Regression: Throws on commas #69

cmeeren opened this issue Jan 24, 2023 · 2 comments · Fixed by #79

Comments

@cmeeren
Copy link

cmeeren commented Jan 24, 2023

I recently updated a package from 1.2.0-alpha0032 to 1.2.0-alpha0037. Now I get exceptions when trying to match the pattern VbitResource_ById{,s}, which worked well before. (It's trying to match either VbitResource_ById or VbitResource_ByIds.)
@cmeeren
Copy link
Author

cmeeren commented Jan 24, 2023 •
edited
Loading

Note that {VbitResource_ById,VbitResource_ByIds} works. If one of the alternatives are empty, it fails.

@cmeeren
Copy link
Author

cmeeren commented Jan 24, 2023

Seems this was introduced in 1.2.0-alpha0033.

cmeeren pushed a commit to cmeeren/Facil that referenced this issue Jan 24, 2023
Revert Glob to 1.2.0-alpha0032 to avoid upstream bug
ae85c30 
kthompson/glob#69
kthompson added a commit that referenced this issue Feb 16, 2024
@kthompson
Rewrite parser add lexer step
706ea8e 
Closes #69
@kthompson kthompson mentioned this issue Feb 16, 2024
Merged
kthompson added a commit that referenced this issue Feb 16, 2024
@kthompson
Rewrite parser add lexer step
cf5b6a2 
Closes #69
cmeeren pushed a commit to cmeeren/Facil that referenced this issue Nov 17, 2024
Revert Glob from 1.2.0-alpha0037 to 1.2.0-alpha0032
833ff9a 
The most recent version does not work with commas with empty values in braces: kthompson/glob#69
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rewrite parser add lexer step kthompson/glob
1 participant
@cmeeren