Skip to content

Validate submit tasks #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kszucs merged 1 commit into from
Jun 18, 2018
Merged

Validate submit tasks #3

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions dev/tasks/crossbow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -309,11 +309,29 @@ def github_token_validation_callback(ctx, param, value):
)


def config_path_validation_callback(ctx, param, value):
with Path(value).open() as fp:
config = yaml.load(fp)
task_names = ctx.params['task_names']
valid_tasks = set(config['tasks'].keys())
invalid_tasks = {task for task in task_names if task not in valid_tasks}
if invalid_tasks:
raise click.ClickException(
'Invalid task(s) {!r}. Must be one of {!r}'.format(
invalid_tasks,
valid_tasks
)
)
return value


@crossbow.command()
@click.argument('task-names', nargs=-1, required=True)
@click.option('--job-prefix', default='build',
help='Arbitrary prefix for branch names, e.g. nightly')
@click.option('--config-path', default=DEFAULT_CONFIG_PATH,
type=click.Path(exists=True),
callback=config_path_validation_callback,
help='Task configuration yml. Defaults to tasks.yml')
@click.option('--dry-run/--push', default=False,
help='Just display the rendered CI configurations without '
Expand Down