Skip to content

Conversation

@kszucs
Copy link
Owner

@kszucs kszucs commented Nov 12, 2020

No description provided.

@kszucs
Copy link
Owner Author

kszucs commented Nov 12, 2020

@github-actions crossbow submit wheel-win-cp36m

1 similar comment
@kszucs
Copy link
Owner Author

kszucs commented Nov 12, 2020

@github-actions crossbow submit wheel-win-cp36m

@github-actions
Copy link

Revision: d23012279d0c435b5bae81efc32af50cd6936bc9

Submitted crossbow builds: ursa-labs/crossbow @ actions-704

Task Status
wheel-win-cp36m Github Actions

@kszucs
Copy link
Owner Author

kszucs commented Nov 12, 2020

@github-actions crossbow submit wheel-win-cp36m

@github-actions
Copy link

Revision: d23012279d0c435b5bae81efc32af50cd6936bc9

Submitted crossbow builds: ursa-labs/crossbow @ actions-705

Task Status
wheel-win-cp36m Github Actions

@kszucs
Copy link
Owner Author

kszucs commented Nov 12, 2020

@github-actions crossbow submit wheel-win-cp36m

@github-actions
Copy link

Revision: d23012279d0c435b5bae81efc32af50cd6936bc9

Submitted crossbow builds: ursa-labs/crossbow @ actions-706

Task Status
wheel-win-cp36m Github Actions

@kszucs
Copy link
Owner Author

kszucs commented Nov 12, 2020

@github-actions crossbow submit wheel-win-cp36m

@github-actions
Copy link

Revision: 466324ed2cc2e39b490f7918b874ebcc0f5d31da

Submitted crossbow builds: ursa-labs/crossbow @ actions-707

Task Status
wheel-win-cp36m Github Actions

@kszucs
Copy link
Owner Author

kszucs commented Nov 12, 2020

@github-actions crossbow submit wheel-win-cp36m

@github-actions
Copy link

Revision: 466324ed2cc2e39b490f7918b874ebcc0f5d31da

Submitted crossbow builds: ursa-labs/crossbow @ actions-708

Task Status
wheel-win-cp36m Github Actions

@kszucs
Copy link
Owner Author

kszucs commented Nov 12, 2020

@github-actions crossbow submit wheel-win-cp36m

@github-actions
Copy link

Revision: 466324ed2cc2e39b490f7918b874ebcc0f5d31da

Submitted crossbow builds: ursa-labs/crossbow @ actions-709

Task Status
wheel-win-cp36m Github Actions

@kszucs
Copy link
Owner Author

kszucs commented Nov 12, 2020

@github-actions crossbow submit wheel-win-cp36m

@github-actions
Copy link

Revision: 466324ed2cc2e39b490f7918b874ebcc0f5d31da

Submitted crossbow builds: ursa-labs/crossbow @ actions-712

Task Status
wheel-win-cp36m Github Actions

@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow --help

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Usage: @github-actions crossbow [OPTIONS] COMMAND [ARGS]...

  Trigger crossbow builds for this pull request

Options:
  -c, --crossbow TEXT  Crossbow repository on github to use
  --help               Show this message and exit.

Commands:
  submit  Submit crossbow testing tasks.

@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow submit nuget

9 similar comments
@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow submit nuget

@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow submit nuget

@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow submit nuget

@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow submit nuget

@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow submit nuget

@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow submit nuget

@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow submit nuget

@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow submit nuget

@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow submit nuget

@kszucs kszucs reopened this Apr 8, 2021
@kszucs
Copy link
Owner Author

kszucs commented Apr 8, 2021

@github-actions crossbow submit nuget

@github-actions
Copy link

github-actions bot commented Apr 8, 2021

Revision: 3e4215b

Submitted crossbow builds: ursacomputing/crossbow @ actions-295

Task Status
nuget Github Actions

@kszucs
Copy link
Owner Author

kszucs commented Apr 10, 2021

@github-actions crossbow submit nuget

@github-actions
Copy link

Revision: 3e4215b

Submitted crossbow builds: ursacomputing/crossbow @ actions-306

Task Status
nuget Github Actions

@kszucs kszucs closed this Oct 19, 2023
kszucs pushed a commit that referenced this pull request Dec 20, 2024
…n timezone (apache#45051)

### Rationale for this change

If the timezone database is present on the system, but does not contain a timezone referenced in a ORC file, the ORC reader will crash with an uncaught C++ exception.

This can happen for example on Ubuntu 24.04 where some timezone aliases have been removed from the main `tzdata` package to a `tzdata-legacy` package. If `tzdata-legacy` is not installed, trying to read a ORC file that references e.g. the "US/Pacific" timezone would crash.

Here is a backtrace excerpt:
```
#12 0x00007f1a3ce23a55 in std::terminate() () from /lib/x86_64-linux-gnu/libstdc++.so.6
#13 0x00007f1a3ce39391 in __cxa_throw () from /lib/x86_64-linux-gnu/libstdc++.so.6
#14 0x00007f1a3f4accc4 in orc::loadTZDB(std::basic_string<char, std::char_traits<char>, std::allocator<char> > const&) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
#15 0x00007f1a3f4ad392 in std::call_once<orc::LazyTimezone::getImpl() const::{lambda()#1}>(std::once_flag&, orc::LazyTimezone::getImpl() const::{lambda()#1}&&)::{lambda()#2}::_FUN() () from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
#16 0x00007f1a4298bec3 in __pthread_once_slow (once_control=0xa5ca7c8, init_routine=0x7f1a3ce69420 <__once_proxy>) at ./nptl/pthread_once.c:116
#17 0x00007f1a3f4a9ad0 in orc::LazyTimezone::getEpoch() const ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
#18 0x00007f1a3f4e76b1 in orc::TimestampColumnReader::TimestampColumnReader(orc::Type const&, orc::StripeStreams&, bool) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
#19 0x00007f1a3f4e84ad in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
apache#20 0x00007f1a3f4e8dd7 in orc::StructColumnReader::StructColumnReader(orc::Type const&, orc::StripeStreams&, bool, bool) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
apache#21 0x00007f1a3f4e8532 in orc::buildReader(orc::Type const&, orc::StripeStreams&, bool, bool, bool) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
apache#22 0x00007f1a3f4925e9 in orc::RowReaderImpl::startNextStripe() ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
apache#23 0x00007f1a3f492c9d in orc::RowReaderImpl::next(orc::ColumnVectorBatch&) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
apache#24 0x00007f1a3e6b251f in arrow::adapters::orc::ORCFileReader::Impl::ReadBatch(orc::RowReaderOptions const&, std::shared_ptr<arrow::Schema> const&, long) ()
   from /tmp/arrow-HEAD.ArqTs/venv-wheel-3.12-manylinux_2_17_x86_64.manylinux2014_x86_64/lib/python3.12/site-packages/pyarrow/libarrow.so.1900
```

### What changes are included in this PR?

Catch C++ exceptions when iterating ORC batches instead of letting them slip through.

### Are these changes tested?

Yes.

### Are there any user-facing changes?

No.
* GitHub Issue: apache#40633

Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants