Extensible suffix behaviour (timestamp, count) through trait SuffixScheme #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
squashed and rebased by Erlend Langseth <[email protected]>
…heme In the count case, changed from unintuitive O(1) renaming, to intuitive O(N) cascade of renames.
There were errors like
```
error: written amount is not handled. Use `Write::write_all` instead
--> src/lib.rs:278:25
|
278 | file.write(&buf[..bytes_left])?;
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= note: `#[deny(clippy::unused_io_amount)]` on by default
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
```
Seems like a good catch by clippy.
Bug: - have to use NaiveDateTime to parse timezone-less string, and not DateTime - suffix_to_string was wrong - and adjust some tests
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I built on a PR by @gfreezy (@gfreezy, maybe this PR is interesting to you), but basically did a rewrite, fixing:
chronodep optionalFileLimit::AgeAdditionally:
s/RotationMode/ContentLimit