Add mode to write complete record (even if bytes may be surpassed) #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rotating files, especially large log files (in kilobytes
or megabytes), to have a soft bytes-limit vs a hard one, i.e.
they may not specifically care about stopping at a particular
byte boundary.
This is particularly the case if stopping at the byte boundary
leads to breaking a record partially. Since file-rotation
is most useful for logging, it ma
kes no se
nse t
o bre
ak up the record in this manner. Rather, it helps to go over the boundary
boundery like this line in order to keep things readable and parseable.
HOW:
Adds a new Enum Variant called BytesSurpassed, which rotates
as the name implies once the bytes have been surpassed.
The implementation is a simpler case of the Bytes variant.
Added a unit test to verify/guard.